[PR #2356] [MERGED] [core] cleanup (remove # App Default Values) #3721

Closed
opened 2026-02-26 13:34:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2356
Author: @MickLesk
Created: 2/13/2025
Status: Merged
Merged: 2/13/2025
Merged by: @michelroegl-brunner

Base: mainHead: cleanup_ct


📝 Commits (5)

  • 5570195 [core] cleanup (remove base_settings & unneeded comments)
  • 625434b remove App Default Values
  • bb19ad4 Add Sources, Oneliner License
  • ca512e1 remove app default values
  • 3e0760b fix wrong source paths

📊 Changes

257 files changed (+32 additions, -1280 deletions)

View changed files

📝 .github/CONTRIBUTOR_GUIDE/ct/AppName.md (+0 -5)
📝 .github/CONTRIBUTOR_GUIDE/ct/AppName.sh (+0 -4)
📝 ct/2fauth.sh (+0 -5)
📝 ct/actualbudget.sh (+0 -5)
📝 ct/adguard.sh (+0 -5)
📝 ct/adventurelog.sh (+0 -5)
📝 ct/agentdvr.sh (+0 -5)
📝 ct/alpine-docker.sh (+1 -5)
📝 ct/alpine-grafana.sh (+1 -5)
📝 ct/alpine-it-tools.sh (+1 -6)
📝 ct/alpine-nextcloud.sh (+2 -6)
📝 ct/alpine-vaultwarden.sh (+1 -5)
📝 ct/alpine-zigbee2mqtt.sh (+1 -5)
📝 ct/alpine.sh (+1 -5)
📝 ct/apache-cassandra.sh (+0 -5)
📝 ct/apache-couchdb.sh (+0 -5)
📝 ct/apache-guacamole.sh (+1 -6)
📝 ct/apache-tika.sh (+0 -5)
📝 ct/apt-cacher-ng.sh (+0 -5)
📝 ct/archivebox.sh (+0 -5)

...and 80 more files

📄 Description

✍️ Description

  • general cleanup of # App Default Values
  • add missing sources
  • do some license parts into 1 liner

Link: #

Prerequisites

Before this PR can be reviewed, the following must be completed:

  • Self-review performed – Code follows established patterns and conventions.
  • Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

  • New feature – Adds new, non-breaking functionality.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2356 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 2/13/2025 **Status:** ✅ Merged **Merged:** 2/13/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `cleanup_ct` --- ### 📝 Commits (5) - [`5570195`](https://github.com/community-scripts/ProxmoxVE/commit/55701952937bf641810d10c0b9b9afed3b1f8fac) [core] cleanup (remove base_settings & unneeded comments) - [`625434b`](https://github.com/community-scripts/ProxmoxVE/commit/625434b4846e4c12c34bc1438e9c50029200b438) remove App Default Values - [`bb19ad4`](https://github.com/community-scripts/ProxmoxVE/commit/bb19ad4f724077bb0b9f3f4629f2b2d0e6b25171) Add Sources, Oneliner License - [`ca512e1`](https://github.com/community-scripts/ProxmoxVE/commit/ca512e100bed603fb5ee97057b05d97644a7955f) remove app default values - [`3e0760b`](https://github.com/community-scripts/ProxmoxVE/commit/3e0760b23810d8f12f4bf4c2a7a62f2a79111517) fix wrong source paths ### 📊 Changes **257 files changed** (+32 additions, -1280 deletions) <details> <summary>View changed files</summary> 📝 `.github/CONTRIBUTOR_GUIDE/ct/AppName.md` (+0 -5) 📝 `.github/CONTRIBUTOR_GUIDE/ct/AppName.sh` (+0 -4) 📝 `ct/2fauth.sh` (+0 -5) 📝 `ct/actualbudget.sh` (+0 -5) 📝 `ct/adguard.sh` (+0 -5) 📝 `ct/adventurelog.sh` (+0 -5) 📝 `ct/agentdvr.sh` (+0 -5) 📝 `ct/alpine-docker.sh` (+1 -5) 📝 `ct/alpine-grafana.sh` (+1 -5) 📝 `ct/alpine-it-tools.sh` (+1 -6) 📝 `ct/alpine-nextcloud.sh` (+2 -6) 📝 `ct/alpine-vaultwarden.sh` (+1 -5) 📝 `ct/alpine-zigbee2mqtt.sh` (+1 -5) 📝 `ct/alpine.sh` (+1 -5) 📝 `ct/apache-cassandra.sh` (+0 -5) 📝 `ct/apache-couchdb.sh` (+0 -5) 📝 `ct/apache-guacamole.sh` (+1 -6) 📝 `ct/apache-tika.sh` (+0 -5) 📝 `ct/apt-cacher-ng.sh` (+0 -5) 📝 `ct/archivebox.sh` (+0 -5) _...and 80 more files_ </details> ### 📄 Description ## ✍️ Description - general cleanup of # App Default Values - add missing sources - do some license parts into 1 liner ## 🔗 Related PR / Discussion / Issue Link: # ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [x] **Self-review performed** – Code follows established patterns and conventions. - [x] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change - [x] ✨ **New feature** – Adds new, non-breaking functionality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 13:34:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#3721
No description provided.