starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-26 09:46:06 +03:00

[PR #2348] [CLOSED] Move VaultWarden service stop until after compilation to reduce downtime while updating #3714

New issue

Closed

opened 2026-02-26 13:34:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:34:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2348
Author: @slackish
Created: 2/13/2025
Status: ❌ Closed

Base: main ← Head: avoid_vw_downtime

📝 Commits (1)

da22117 Move service stop until after compliation to reduce downtime

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 ct/vaultwarden.sh (+5 -3)

📄 Description

✍️ Description

To minimize the downtime of the vaultwarden service, this change moves the service stop until after the new release is compiled and ready to be copied in place.

Link: #

✅ Prerequisites

Before this PR can be reviewed, the following must be completed:

[] Self-review performed – Code follows established patterns and conventions.
[] Testing performed – Changes have been thoroughly tested and verified.

🛠️ Type of Change

Select all that apply:

[] 🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
[] 💥 Breaking change – Alters existing functionality in a way that may require updates.
[] 🆕 New script – A fully functional and tested script or script set.

📋 Additional Information (optional)

For a quick characterization of downtime, on a container with recommended hardware requirements in proxmox running on a i5-6500 with disk backed by ceph, I observed that the cargo build step took 13m8.347s of wall/real time.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2348 **Author:** [@slackish](https://github.com/slackish) **Created:** 2/13/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `avoid_vw_downtime` --- ### 📝 Commits (1) - [`da22117`](https://github.com/community-scripts/ProxmoxVE/commit/da2211716dcf1ec70cf9555d013649d5a076246c) Move service stop until after compliation to reduce downtime ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ct/vaultwarden.sh` (+5 -3) </details> ### 📄 Description ## ✍️ Description To minimize the downtime of the vaultwarden service, this change moves the service stop until after the new release is compiled and ready to be copied in place. ## 🔗 Related PR / Discussion / Issue Link: # ## ✅ Prerequisites Before this PR can be reviewed, the following must be completed: - [] **Self-review performed** – Code follows established patterns and conventions. - [] **Testing performed** – Changes have been thoroughly tested and verified. ## 🛠️ Type of Change Select all that apply: - [] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [x] ✨ **New feature** – Adds new, non-breaking functionality. - [] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. - [] 🆕 **New script** – A fully functional and tested script or script set. ## 📋 Additional Information (optional) For a quick characterization of downtime, on a container with recommended hardware requirements in proxmox running on a i5-6500 with disk backed by ceph, I observed that the `cargo build` step took 13m8.347s of wall/real time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:34:25 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 14:31:08 +03:00

[PR #3714] [MERGED] [core] update date in json #4489

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3714

No description provided.

Rows
Columns