[GH-ISSUE #204] Fix Default Logo & also backoff if logo does not load #37

New issue

Closed

opened 2026-02-26 12:44:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:44:12 +03:00

Owner

Originally created by @newzealandpaul on GitHub (Nov 13, 2024).
Original GitHub issue: https://github.com/community-scripts/ProxmoxVE/issues/204

Originally assigned to: @BramSuurdje on GitHub.

Please verify that you have read and understood the guidelines.

yes

A clear and concise description of the issue.

If a logo link breaks in the JSON (either the link is outdated, or there is a typo in the link), the website will continue to to request a logo from this URL:

https://community-scripts.github.io/logo.png

The script will continually pull until the user is rate blocked by github and cannot access the website.

Please provide a description of the expected behavior.

A default logo is shown, no logo will be requested more than once. If it doesn't load, show a placeholder.

If relevant, including screenshots or a code block can be helpful in clarifying the issue.

Please provide detailed steps to reproduce the issue.

Visit a script page, such as:

https://community-scripts.github.io/ProxmoxVE/scripts?id=bookstack

Then using dev tools change the logo address to a url that will 404, then watch in the console as requests are made to https://community-scripts.github.io/logo.png

Originally created by @newzealandpaul on GitHub (Nov 13, 2024). Original GitHub issue: https://github.com/community-scripts/ProxmoxVE/issues/204 Originally assigned to: @BramSuurdje on GitHub. ### Please verify that you have read and understood the guidelines. yes ### A clear and concise description of the issue. If a logo link breaks in the JSON (either the link is outdated, or there is a typo in the link), the website will continue to to request a logo from this URL: https://community-scripts.github.io/logo.png The script will continually pull until the user is rate blocked by github and cannot access the website. ### Please provide a description of the expected behavior. A default logo is shown, no logo will be requested more than once. If it doesn't load, show a placeholder. ### If relevant, including screenshots or a code block can be helpful in clarifying the issue. <img width="518" alt="Screenshot 2024-11-13 at 1 33 31 PM" src="https://github.com/user-attachments/assets/406ad5c1-b761-4fd5-a0e0-f43c4496fec3"> ### Please provide detailed steps to reproduce the issue. Visit a script page, such as: https://community-scripts.github.io/ProxmoxVE/scripts?id=bookstack Then using dev tools change the logo address to a url that will 404, then watch in the console as requests are made to https://community-scripts.github.io/logo.png