[PR #2121] [MERGED] Fix JSON-Editor #3552

Closed
opened 2026-02-26 13:33:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2121
Author: @michelroegl-brunner
Created: 2/7/2025
Status: Merged
Merged: 2/7/2025
Merged by: @michelroegl-brunner

Base: mainHead: json-editor-patch


📝 Commits (1)

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 frontend/src/app/json-editor/_components/InstallMethod.tsx (+2 -2)
📝 frontend/src/app/json-editor/page.tsx (+2 -2)

📄 Description

✍️ Description

Fixes a issue with the JSON Editor where it puts a leading / when selecting VM or MISC

Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • [] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

When Type is LXC it works:
image

When changin to VM or MISC it puts a leading /
image

After switching back to LXC the slash stays:
image

With the fix:
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2121 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/7/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `json-editor-patch` --- ### 📝 Commits (1) - [`48083ee`](https://github.com/community-scripts/ProxmoxVE/commit/48083eeb9803223b66a0bb7e3fb3c8762b25e37b) Fix JSON-Editor ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/app/json-editor/_components/InstallMethod.tsx` (+2 -2) 📝 `frontend/src/app/json-editor/page.tsx` (+2 -2) </details> ### 📄 Description ## ✍️ Description Fixes a issue with the JSON Editor where it puts a leading / when selecting VM or MISC ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [X] Testing performed (I have thoroughly tested my changes and verified expected functionality.) ## 🛠️ Type of Change Please check the relevant options: - [X] Bug fix (non-breaking change that resolves an issue) - [] New feature (non-breaking change that adds functionality) - [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [] New script (a fully functional and thoroughly tested script or set of scripts) --- ## 📋 Additional Information (optional) When Type is LXC it works: ![image](https://github.com/user-attachments/assets/f0ce7157-06fd-49bf-a400-eb19839632bf) When changin to VM or MISC it puts a leading / ![image](https://github.com/user-attachments/assets/9a18f5d8-3425-45d6-b9f8-acda2dfc8411) After switching back to LXC the slash stays: ![image](https://github.com/user-attachments/assets/87052c73-e6df-48f1-911f-de2dc7464dbd) With the fix: ![image](https://github.com/user-attachments/assets/5edabf89-55f1-4bd2-8eb6-14adfd3057e5) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 13:33:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#3552
No description provided.