starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 09:15:59 +03:00

[PR #2049] [MERGED] [API] Update create-lxc.sh / Improve error messages #1 #3505

New issue

Closed

opened 2026-02-26 13:33:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:33:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2049
Author: @michelroegl-brunner
Created: 2/5/2025
Status: ✅ Merged
Merged: 2/5/2025
Merged by: @michelroegl-brunner

Base: main ← Head: updated_create_lxc.sh

📝 Commits (3)

819d3ff update create-lxc.sh
1bf4f6b [core] Ignore create_lxc.sh at validate filename (#2059)
ac0babc Update validate-filenames.yml

📊 Changes

2 files changed (+19 additions, -10 deletions)

View changed files

📝 .github/workflows/validate-filenames.yml (+5 -1)
📝 ct/create_lxc.sh (+14 -9)

📄 Description

✍️ Description

This PR updates create-lxc.sh and reworks the error messages.
Befor it was just error "some string", but this never kills the the spinner and leaves the shell in a unwanted state.

I´ve updated the error messages to use msg_error "some string" to better handel this case.

In preperation for better error messages each error gets its own designated error code, to send the correct message to the api.

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

[] Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
[] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Before change:

After change:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2049 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 2/5/2025 **Status:** ✅ Merged **Merged:** 2/5/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `updated_create_lxc.sh` --- ### 📝 Commits (3) - [`819d3ff`](https://github.com/community-scripts/ProxmoxVE/commit/819d3ff52a72af67058b32c4daeded6beab572a9) update create-lxc.sh - [`1bf4f6b`](https://github.com/community-scripts/ProxmoxVE/commit/1bf4f6b91fb2474ee5e92d6a6a3133ba1ac72b70) [core] Ignore create_lxc.sh at validate filename (#2059) - [`ac0babc`](https://github.com/community-scripts/ProxmoxVE/commit/ac0babc84997bdb1600859289ccb488f65691160) Update validate-filenames.yml ### 📊 Changes **2 files changed** (+19 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/validate-filenames.yml` (+5 -1) 📝 `ct/create_lxc.sh` (+14 -9) </details> ### 📄 Description ## ✍️ Description This PR updates create-lxc.sh and reworks the error messages. Befor it was just `error "some string"`, but this never kills the the spinner and leaves the shell in a unwanted state. I´ve updated the error messages to use `msg_error "some string"` to better handel this case. In preperation for better error messages each error gets its own designated error code, to send the correct message to the api. ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [X] Testing performed (I have thoroughly tested my changes and verified expected functionality.) ## 🛠️ Type of Change Please check the relevant options: - [] Bug fix (non-breaking change that resolves an issue) - [X] New feature (non-breaking change that adds functionality) - [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [] New script (a fully functional and thoroughly tested script or set of scripts) --- ## 📋 Additional Information (optional) Before change: ![image](https://github.com/user-attachments/assets/5208d0d5-b88f-48fb-b182-2db9e6b0ad79) After change: ![image](https://github.com/user-attachments/assets/d4d6b96a-0ce1-4daa-99fd-411516e83bbf) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:33:44 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 14:30:47 +03:00

[PR #3506] [MERGED] Open WebUI: Fix Ollama update logic #4374

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3505

No description provided.

Rows
Columns