starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 01:06:06 +03:00

[PR #2027] [MERGED] Fix actual update - missing hidden files, downloaded release cleanup #3490

New issue

Closed

opened 2026-02-26 13:33:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:33:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/2027
Author: @maciejmatczak
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/4/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix-actual-update

📝 Commits (2)

f31b0c2 Fix Actual Budget update: download and copy release exactly how in install script
bfcde92 Fix Actual Budget update: removing wget release tar gz

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 ct/actualbudget.sh (+2 -3)

📄 Description

✍️ Description

Fixes #1707.

Update script had different logic around folder and file movement when compared to install script, I followed install script logic.

Update script did not move the hidden files (dotfiles) from newly downloaded release of Actual Budget due to bash, by default, not matching dot files (mv *ctual-server-*/* behavior depends on bash's dotglob option).

The bottom rm -rf of .tar.gz seemed not effective - I updated it to follow install script logic.

Related Issue: #1707
Related PR: #
Related Discussion: #

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

Bug fix (non-breaking change that resolves an issue)
[] New feature (non-breaking change that adds functionality)
[] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
[] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/2027 **Author:** [@maciejmatczak](https://github.com/maciejmatczak) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/4/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix-actual-update` --- ### 📝 Commits (2) - [`f31b0c2`](https://github.com/community-scripts/ProxmoxVE/commit/f31b0c2a72969d5294270fb597851db065f75c2a) Fix Actual Budget update: download and copy release exactly how in install script - [`bfcde92`](https://github.com/community-scripts/ProxmoxVE/commit/bfcde92fd558dc7f9be2a189664b60f40034afa2) Fix Actual Budget update: removing wget release tar gz ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ct/actualbudget.sh` (+2 -3) </details> ### 📄 Description ## ✍️ Description Fixes #1707. Update script had different logic around folder and file movement when compared to install script, I followed install script logic. Update script did not move the hidden files (dotfiles) from newly downloaded release of Actual Budget due to bash, by default, not matching dot files (`mv *ctual-server-*/*` behavior depends on bash's `dotglob` option). The bottom `rm -rf` of `.tar.gz` seemed not effective - I updated it to follow install script logic. - - - - Related Issue: #1707 - Related PR: # - Related Discussion: # - - - ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [] New feature (non-breaking change that adds functionality) - [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [] New script (a fully functional and thoroughly tested script or set of scripts) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:33:41 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 14:30:45 +03:00

[PR #3490] [MERGED] [Github Action] Update CHANGELOG.md #4365

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3490

No description provided.

Rows
Columns