[PR #1802] [MERGED] [core]: Remove Figlet | Get Headers by Repo & Store Local #3360

Closed
opened 2026-02-26 13:33:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1802
Author: @MickLesk
Created: 1/28/2025
Status: Merged
Merged: 1/28/2025
Merged by: @MickLesk

Base: mainHead: MickLesk-patch-1


📝 Commits (2)

  • 2351088 [core]: Remove Figlet | Get Headers by Repo & Store Local
  • 34dd9c9 change repo

📊 Changes

1 file changed (+26 additions, -50 deletions)

View changed files

📝 misc/build.func (+26 -50)

📄 Description

✍️ Description

  • Remove Figlet Generation on LXC's and Proxmox Nodes
  • Get Headers by repo, if not an header available -> doenst show header
  • Store Headers local, dont need an active internet connection after create/update for this.

=> Work with an GH Action in our repo, files stored in ct/headers

Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • [] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1802 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 1/28/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `MickLesk-patch-1` --- ### 📝 Commits (2) - [`2351088`](https://github.com/community-scripts/ProxmoxVE/commit/235108830825303f26cbfe1f7926aa91444df139) [core]: Remove Figlet | Get Headers by Repo & Store Local - [`34dd9c9`](https://github.com/community-scripts/ProxmoxVE/commit/34dd9c94caef9438dd2836f5765d0d4daced608b) change repo ### 📊 Changes **1 file changed** (+26 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+26 -50) </details> ### 📄 Description ## ✍️ Description - Remove Figlet Generation on LXC's and Proxmox Nodes - Get Headers by repo, if not an header available -> doenst show header - Store Headers local, dont need an active internet connection after create/update for this. => Work with an GH Action in our repo, files stored in ct/headers ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [] New script (a fully functional and thoroughly tested script or set of scripts) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 13:33:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#3360
No description provided.