starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 09:15:59 +03:00

[PR #1513] [CLOSED] Update to filebrowser.sh allowing port selection #3209

New issue

Closed

opened 2026-02-26 13:32:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:32:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1513
Author: @mellow65
Created: 1/16/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (2)

baecdb7 Update filebrowser.sh
4451733 Merge pull request #1 from mellow65/mellow65-patch-1

📊 Changes

1 file changed (+15 additions, -2 deletions)

View changed files

📝 misc/filebrowser.sh (+15 -2)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.

✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.

While it may have been a special case for me, I ran into port conflictions when loading file browser and then another program that used 8080 as a default port. I was able to address my use case, but having the option to change the default port on install could have saved me a lot of frustration.

I have added an additional prompt to ask whether you want to change the default port, and what you would want to change it to. But also has the option leave it as is. I have done my best to follow the same coloring scheme as before. In all of my testing the additional script works as expected.

🛠️ Type of Change

Please check the relevant options:

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
Testing performed (I have thoroughly tested my changes and verified expected functionality.)
Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1513 **Author:** [@mellow65](https://github.com/mellow65) **Created:** 1/16/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`baecdb7`](https://github.com/community-scripts/ProxmoxVE/commit/baecdb7f67a3f1058e1bfff690eee0c8d197d4b5) Update filebrowser.sh - [`4451733`](https://github.com/community-scripts/ProxmoxVE/commit/4451733fc01f46332a286c3f297cd4d87ec5b776) Merge pull request #1 from mellow65/mellow65-patch-1 ### 📊 Changes **1 file changed** (+15 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `misc/filebrowser.sh` (+15 -2) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description Provide a summary of the changes made and/or reference the issue being addressed. While it may have been a special case for me, I ran into port conflictions when loading file browser and then another program that used 8080 as a default port. I was able to address my use case, but having the option to change the default port on install could have saved me a lot of frustration. I have added an additional prompt to ask whether you want to change the default port, and what you would want to change it to. But also has the option leave it as is. I have done my best to follow the same coloring scheme as before. In all of my testing the additional script works as expected. --- ## 🛠️ Type of Change Please check the relevant options: - [ ] Bug fix (non-breaking change that resolves an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [X] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [X] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:32:46 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 13:35:59 +03:00

[PR #3209] [MERGED] Seafile: lowercase slug for Install/Update-Source #4199

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3209

No description provided.

Rows
Columns