starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 09:15:59 +03:00

[PR #1502] [MERGED] [core] build.func&install.func: Fix ssh keynot added error #3207

New issue

Closed

opened 2026-02-26 13:32:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:32:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1502
Author: @dsiebel
Created: 1/15/2025
Status: ✅ Merged
Merged: 1/15/2025
Merged by: @MickLesk

Base: main ← Head: fix-root-ssh-key-install

📝 Commits (1)

1b1a94b fix: actually add the given root SSH key to the container

📊 Changes

2 files changed (+8 additions, -0 deletions)

View changed files

📝 misc/build.func (+1 -0)
📝 misc/install.func (+7 -0)

📄 Description

✍️ Description

A PR I created for develop was recently cherry-picked into main (#1456), but it only contained one half of the changes.
The SSH key that can be specified during advanced setup was not being added to the container.
This PR addresses that, recovering the changes made in the original PR.

Related PR: #1456
Related PR: #1060
Related Discussion: #860

🛠️ Type of Change

Please check the relevant options:

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
Testing performed (I have thoroughly tested my changes and verified expected functionality.)
Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

When creating the original PR, I was also pondering the idea of skipping the part that replaces

PermitRootLogin prohibit-password`

with

PermitRootLogin yes

in the sshd config, when a root password has been set.
What do you think, would this be a worthy improvement?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1502 **Author:** [@dsiebel](https://github.com/dsiebel) **Created:** 1/15/2025 **Status:** ✅ Merged **Merged:** 1/15/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `fix-root-ssh-key-install` --- ### 📝 Commits (1) - [`1b1a94b`](https://github.com/community-scripts/ProxmoxVE/commit/1b1a94b31489aabe52900766b8ca53a4839a03bd) fix: actually add the given root SSH key to the container ### 📊 Changes **2 files changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+1 -0) 📝 `misc/install.func` (+7 -0) </details> ### 📄 Description ## ✍️ Description A [PR I created for `develop`](#1060) was recently cherry-picked into `main` (#1456), but it only contained one half of the changes. The SSH key that can be specified during advanced setup was not being added to the container. This PR addresses that, recovering the changes made in the original PR. - Related PR: #1456 - Related PR: #1060 - Related Discussion: #860 --- ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [ ] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) When creating the original PR, I was also pondering the idea of skipping the part that replaces ``` PermitRootLogin prohibit-password` ``` with ``` PermitRootLogin yes ``` in the sshd config, when a root password has been set. What do you think, would this be a worthy improvement? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:32:46 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 13:35:59 +03:00

[PR #3207] [MERGED] Tandoor: Extend needed dependencies (Read for Update-Functionality) #4198

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3207

No description provided.

Rows
Columns