[PR #1382] [MERGED] [Core] add Github Action for Generate AppHeaders (figlet remove part 1) #3142

Closed
opened 2026-02-26 13:32:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1382
Author: @MickLesk
Created: 1/10/2025
Status: Merged
Merged: 1/10/2025
Merged by: @MickLesk

Base: mainHead: figlet_generation


📝 Commits (3)

  • dd29041 add figlet generation files
  • 2ff536f Update generate-app-headers.yaml
  • 87b442e Update generate-app-headers.sh

📊 Changes

2 files changed (+74 additions, -0 deletions)

View changed files

.github/workflows/generate-app-headers.sh (+33 -0)
.github/workflows/generate-app-headers.yaml (+41 -0)

📄 Description

✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.

  • Step 1, generate files in github with action
  • Step 2 (Later) change build.func

Goal: Figlet not used on own lxcs and installations, only 1 file that updated in build.func automatically in /opt/.app-headers


Please remove unneeded lines!


🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)
  • Documentation updated (I have updated any relevant documentation)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1382 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/10/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `figlet_generation` --- ### 📝 Commits (3) - [`dd29041`](https://github.com/community-scripts/ProxmoxVE/commit/dd29041e4c53d3b268bf92b02e89411ce4faeca9) add figlet generation files - [`2ff536f`](https://github.com/community-scripts/ProxmoxVE/commit/2ff536f26aa112b4af6e968a83752035723fa647) Update generate-app-headers.yaml - [`87b442e`](https://github.com/community-scripts/ProxmoxVE/commit/87b442ef9e156c903d85114d51c77afca83853c8) Update generate-app-headers.sh ### 📊 Changes **2 files changed** (+74 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/generate-app-headers.sh` (+33 -0) ➕ `.github/workflows/generate-app-headers.yaml` (+41 -0) </details> ### 📄 Description ## ✍️ Description Provide a summary of the changes made and/or reference the issue being addressed. - Step 1, generate files in github with action - Step 2 (Later) change build.func Goal: Figlet not used on own lxcs and installations, only 1 file that updated in build.func automatically in /opt/.app-headers - - - **_Please remove unneeded lines!_** - Related Issue: #1044 #1072 #1133 #1350 #869 --- ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [x] Documentation updated (I have updated any relevant documentation) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 13:32:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#3142
No description provided.