starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-26 01:36:05 +03:00

[PR #1334] [MERGED] Fix: AdventureLog - update script bug #3118

New issue

Closed

opened 2026-02-26 13:32:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:32:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1334
Author: @JesperDramsch
Created: 1/8/2025
Status: ✅ Merged
Merged: 1/9/2025
Merged by: @MickLesk

Base: main ← Head: fix/adventurelog-update

📝 Commits (9)

d531771 refactor: move installation for backup and maintain media and env files
550efb5 fix: return to working directory
a11c5d8 Workdir
0235b13 Workdir
7e766cd Avoid Workdir
45ccdee Avoid Workdir
c5d7608 Remove old installation (at request of @michelroegl-brunner)
4ddac3c rm newline
7c51ef4 rm last version

📊 Changes

1 file changed (+11 additions, -9 deletions)

View changed files

📝 ct/adventurelog.sh (+11 -9)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.

✍️ Description

Adventure log wasn't updating correctly.

This fixes several things:

Move original installation into a backup location
Update installation
Move user-generated data back to installation (media and env files)
Return to PWD, which was left in the script and then files were left strewn around.

Fixes #1331

🛠️ Type of Change

Please check the relevant options:

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
Testing performed (I have thoroughly tested my changes and verified expected functionality.)
Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

I ran the code on my own installation. I made the design decision to keep prior files (sans media due to size) around as AdventureLog is changing quite a bit, which means I don't want to just rm -rf the old installation. But you can make the decision this would be more correct.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1334 **Author:** [@JesperDramsch](https://github.com/JesperDramsch) **Created:** 1/8/2025 **Status:** ✅ Merged **Merged:** 1/9/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `fix/adventurelog-update` --- ### 📝 Commits (9) - [`d531771`](https://github.com/community-scripts/ProxmoxVE/commit/d531771829dfc4417f6afe7439362005f4bff6a9) refactor: move installation for backup and maintain media and env files - [`550efb5`](https://github.com/community-scripts/ProxmoxVE/commit/550efb5e303bbe22b940df1ae2cd40c789af6754) fix: return to working directory - [`a11c5d8`](https://github.com/community-scripts/ProxmoxVE/commit/a11c5d86ec4f65c7214e797973e7f00c9e95bdb5) Workdir - [`0235b13`](https://github.com/community-scripts/ProxmoxVE/commit/0235b1385b154b0587c56b8e5ca1dd581d11b712) Workdir - [`7e766cd`](https://github.com/community-scripts/ProxmoxVE/commit/7e766cdf8ea260da5a07b69c4927f9aa8f00152e) Avoid Workdir - [`45ccdee`](https://github.com/community-scripts/ProxmoxVE/commit/45ccdeef3f168be655bfabaa5576b44dab1ce96f) Avoid Workdir - [`c5d7608`](https://github.com/community-scripts/ProxmoxVE/commit/c5d7608a783ec4cc3f062ab2ac3ba46f1e4e2208) Remove old installation (at request of @michelroegl-brunner) - [`4ddac3c`](https://github.com/community-scripts/ProxmoxVE/commit/4ddac3c1a674997713ce7c2c672f6b23730b126a) rm newline - [`7c51ef4`](https://github.com/community-scripts/ProxmoxVE/commit/7c51ef4fa259526b91c1dae857b6e1782ef79e20) rm last version ### 📊 Changes **1 file changed** (+11 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `ct/adventurelog.sh` (+11 -9) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description Adventure log wasn't updating correctly. This fixes several things: 1. Move original installation into a backup location 2. Update installation 3. Move user-generated data back to installation (media and env files) 4. Return to PWD, which was left in the script and then files were left strewn around. Fixes #1331 --- ## 🛠️ Type of Change Please check the relevant options: - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [x] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. I ran the code on my own installation. I made the design decision to keep prior files (sans media due to size) around as AdventureLog is changing quite a bit, which means I don't want to just `rm -rf` the old installation. But you can make the decision this would be more correct. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:32:28 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3118

No description provided.

Rows
Columns