starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 17:26:03 +03:00

[PR #1216] [MERGED] Use profile.d to show the lxc details #3060

New issue

Closed

opened 2026-02-26 13:32:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:32:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1216
Author: @JcMinarro
Created: 1/3/2025
Status: ✅ Merged
Merged: 1/6/2025
Merged by: @MickLesk

Base: profile_d_motd ← Head: move-motd-to-profile

📝 Commits (1)

bebc611 Use profile.d to show the lxc details

📊 Changes

2 files changed (+18 additions, -28 deletions)

View changed files

📝 misc/alpine-install.func (+10 -11)
📝 misc/install.func (+8 -17)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.

✍️ Description

Instead of hardcode data within the /etc/motd file, adding a script on /etc/profile.d/ to load dynamic values as the IP and/or the hostname of the LXC

Please remove unneeded lines!

Related Issue: # (issue number, if applicable)
Related PR: # (if applicable)
Related Discussion: Reply within a PR

🛠️ Type of Change

Please check the relevant options:

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
Testing performed (I have thoroughly tested my changes and verified expected functionality.)
Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1216 **Author:** [@JcMinarro](https://github.com/JcMinarro) **Created:** 1/3/2025 **Status:** ✅ Merged **Merged:** 1/6/2025 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `profile_d_motd` ← **Head:** `move-motd-to-profile` --- ### 📝 Commits (1) - [`bebc611`](https://github.com/community-scripts/ProxmoxVE/commit/bebc611cb54d6f4e740ad4d97799cfa3e9c7df4b) Use profile.d to show the lxc details ### 📊 Changes **2 files changed** (+18 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `misc/alpine-install.func` (+10 -11) 📝 `misc/install.func` (+8 -17) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description Instead of hardcode data within the `/etc/motd` file, adding a script on `/etc/profile.d/` to load dynamic values as the IP and/or the hostname of the LXC - - - **_Please remove unneeded lines!_** - Related Issue: # (issue number, if applicable) - Related PR: # (if applicable) - Related Discussion: [Reply within a PR](https://github.com/community-scripts/ProxmoxVE/pull/643#discussion_r1902063201) --- ## 🛠️ Type of Change Please check the relevant options: - [ ] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [ ] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [ ] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) Provide any extra context or screenshots about the feature or fix here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:32:16 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 13:35:43 +03:00

[PR #3060] [MERGED] [Github Action] Update CHANGELOG.md #4117

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#3060

No description provided.

Rows
Columns