starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-26 01:36:05 +03:00

[PR #1027] [MERGED] ChangeDetection Update: Update also Browsers #2975

New issue

Closed

opened 2026-02-26 13:31:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:31:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/1027
Author: @Niklas04
Created: 12/26/2024
Status: ✅ Merged
Merged: 12/26/2024
Merged by: @MickLesk

Base: main ← Head: main

📝 Commits (2)

48472a9 Changedetection: Update also browsers
628f4ee Changedetection: Adding more msg for updating, Make code more readable

📊 Changes

1 file changed (+19 additions, -2 deletions)

View changed files

📝 ct/changedetection.sh (+19 -2)

📄 Description

✍️ Description

In ChangeDetection-Script (ct/changedetection.sh):

Update also browsers in function update_script
Adding more messages in function update_script
Make function update_script more readable by adding line breaks

Related Issue: #1026

🛠️ Type of Change

Please check the relevant option(s):

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
Testing performed (I have thoroughly tested my changes and verified expected functionality.)
Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

Fix an issue (#1026) that Browserless-service is not starting up after an update of Broswerless and/or Playwright, because now chromium_headless is needed and/or the installed version of the browsers are not compatible anymore.

This fix was verified by me by upgrading from a working backup. Also could reproduce the issue when updating from the working backup beforehand.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/1027 **Author:** [@Niklas04](https://github.com/Niklas04) **Created:** 12/26/2024 **Status:** ✅ Merged **Merged:** 12/26/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`48472a9`](https://github.com/community-scripts/ProxmoxVE/commit/48472a9fefc7c0da4ad6d29f0aad9cfd3640890c) Changedetection: Update also browsers - [`628f4ee`](https://github.com/community-scripts/ProxmoxVE/commit/628f4eec74053ce6d1ea0b2d7f31957195d42fea) Changedetection: Adding more msg for updating, Make code more readable ### 📊 Changes **1 file changed** (+19 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ct/changedetection.sh` (+19 -2) </details> ### 📄 Description ## ✍️ Description In ChangeDetection-Script (ct/changedetection.sh): - Update also browsers in function update_script - Adding more messages in function update_script - Make function update_script more readable by adding line breaks - - - - Related Issue: #1026 --- ## 🛠️ Type of Change Please check the relevant option(s): - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [x] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [x] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) Fix an issue (#1026) that Browserless-service is not starting up after an update of Broswerless and/or Playwright, because now chromium_headless is needed and/or the installed version of the browsers are not compatible anymore. This fix was verified by me by upgrading from a working backup. Also could reproduce the issue when updating from the working backup beforehand. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:31:59 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 13:35:33 +03:00

[PR #2975] [MERGED] Add warnings about externaly sourced scripts #4067

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2975

No description provided.

Rows
Columns