starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 09:15:59 +03:00

[PR #948] [MERGED] Fix: Remove PHP Key generation in Bookstack Update #2946

New issue

Closed

opened 2026-02-26 13:31:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:31:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/948
Author: @michelroegl-brunner
Created: 12/20/2024
Status: ✅ Merged
Merged: 12/20/2024
Merged by: @MickLesk

Base: main ← Head: bookstack_hotfix

📝 Commits (1)

b7f87c4 Hotfix: Remove new Keygeneration in Bookstack Update

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 ct/bookstack.sh (+0 -1)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.

✍️ Description

Removes the Keygeneration in the Update Function. It was in there forever, but is accorfing to the Documentation not necessery: Bookstack Update Doc

Related Issue: #946

🛠️ Type of Change

Please check the relevant options:

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
Testing performed (I have thoroughly tested my changes and verified expected functionality.)
Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/948 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 12/20/2024 **Status:** ✅ Merged **Merged:** 12/20/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `bookstack_hotfix` --- ### 📝 Commits (1) - [`b7f87c4`](https://github.com/community-scripts/ProxmoxVE/commit/b7f87c4a18911015301730a1a20dfcd001522938) Hotfix: Remove new Keygeneration in Bookstack Update ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ct/bookstack.sh` (+0 -1) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description Removes the Keygeneration in the Update Function. It was in there forever, but is accorfing to the Documentation not necessery: [Bookstack Update Doc](https://www.bookstackapp.com/docs/admin/updates/) - - - - Related Issue: #946 --- ## 🛠️ Type of Change Please check the relevant options: - [X] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [X] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:31:54 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2946

No description provided.

Rows
Columns