starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 01:06:06 +03:00

[PR #894] [MERGED] Update build.func to display the Proxmox Hostname #2919

New issue

Closed

opened 2026-02-26 13:31:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:31:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/894
Author: @michelroegl-brunner
Created: 12/18/2024
Status: ✅ Merged
Merged: 12/20/2024
Merged by: @MickLesk

Base: main ← Head: build_dev

📝 Commits (8)

de39e0a Update build.func to display the PROXMOX Hostname
1aabd8b Add to Advanced Settings
6b6567f Changes
21e09f5 Change placement
9a5e5f7 Remove blank line
0404ec3 Changed Style
0209a1f Changes
5edb732 Remove Uppercasing

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 misc/build.func (+5 -5)

📄 Description

🛠️ Note:
We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal!
🎮 Note for game-related scripts: These have a lower likelihood of being merged.

✍️ Description

Provide a summary of the changes made and/or reference the issue being addressed.

Added the function to Display the name of the Proxmox Host during CT creation.

This is probably just a me Problem with my 5 Hosts, but sometimes when you work on more then one Host at a time it would be nice to see the Host you are working on.

I find it is a neat little improvment and adds some verbosity.

You can test it against my dev branch: bash -c "$(wget -qLO - https://raw.githubusercontent.com/michelroegl-brunner/ProxmoxVE/refs/heads/DEV/ct/zammad.sh)"

🛠️ Type of Change

Please check the relevant options:

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts)

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
Testing performed (I have thoroughly tested my changes and verified expected functionality.)
Documentation updated (I have updated any relevant documentation)

📋 Additional Information (optional)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/894 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 12/18/2024 **Status:** ✅ Merged **Merged:** 12/20/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `build_dev` --- ### 📝 Commits (8) - [`de39e0a`](https://github.com/community-scripts/ProxmoxVE/commit/de39e0a10cddcc6575a47c63ffcf7b1a1298317f) Update build.func to display the PROXMOX Hostname - [`1aabd8b`](https://github.com/community-scripts/ProxmoxVE/commit/1aabd8bbfc86048ff3b2318d27db44bf0c769e50) Add to Advanced Settings - [`6b6567f`](https://github.com/community-scripts/ProxmoxVE/commit/6b6567f00f86ff5fa51b8e924ae94a1c6b805f10) Changes - [`21e09f5`](https://github.com/community-scripts/ProxmoxVE/commit/21e09f5aa9a3f6cb293456d24a14db30fe72cdff) Change placement - [`9a5e5f7`](https://github.com/community-scripts/ProxmoxVE/commit/9a5e5f7b808eaa53d2a58a5e562897bdc1af2edd) Remove blank line - [`0404ec3`](https://github.com/community-scripts/ProxmoxVE/commit/0404ec3bbc867b989d823cb2c84447584c46fc33) Changed Style - [`0209a1f`](https://github.com/community-scripts/ProxmoxVE/commit/0209a1f05586315de8b11e8607b9052eb8d2d893) Changes - [`5edb732`](https://github.com/community-scripts/ProxmoxVE/commit/5edb732cb738ac658597d0f29d03686ed3023e47) Remove Uppercasing ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+5 -5) </details> ### 📄 Description > **🛠️ Note:** > We are meticulous about merging code into the main branch, so please understand that pull requests not meeting the project's standards may be rejected. It's never personal! > 🎮 **Note for game-related scripts:** These have a lower likelihood of being merged. --- ## ✍️ Description Provide a summary of the changes made and/or reference the issue being addressed. Added the function to Display the name of the Proxmox Host during CT creation. This is probably just a me Problem with my 5 Hosts, but sometimes when you work on more then one Host at a time it would be nice to see the Host you are working on. I find it is a neat little improvment and adds some verbosity. You can test it against my dev branch: `bash -c "$(wget -qLO - https://raw.githubusercontent.com/michelroegl-brunner/ProxmoxVE/refs/heads/DEV/ct/zammad.sh)"` ## 🛠️ Type of Change Please check the relevant options: - [ ] Bug fix (non-breaking change that resolves an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts) --- ## ✅ Prerequisites The following steps must be completed for the pull request to be considered: - [X] Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.) - [X] Testing performed (I have thoroughly tested my changes and verified expected functionality.) - [ ] Documentation updated (I have updated any relevant documentation) --- ## 📋 Additional Information (optional) ![build_advanced](https://github.com/user-attachments/assets/196e9a32-9573-46f2-a3a4-55cffbb05e4b) ![build_deafult](https://github.com/user-attachments/assets/de958e60-4ca7-4698-a803-12c5dbc9ff65) ![build_deafult_verbose](https://github.com/user-attachments/assets/ddde7bae-e325-44b4-99a0-0b8e8b6a9eaf) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:31:47 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 13:35:27 +03:00

[PR #2919] [CLOSED] Update casaos-install.sh #4034

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2919

No description provided.

Rows
Columns