[PR #723] [MERGED] Fix Hoarder build failure by installing Chromium stable #2854

Closed
opened 2026-02-26 13:31:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/723
Author: @vhsdream
Created: 12/7/2024
Status: Merged
Merged: 12/7/2024
Merged by: @havardthom

Base: mainHead: hoarder-fix


📝 Commits (1)

  • 7db93f4 Fix Hoarder build failure by installing Chromium stable

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 install/hoarder-install.sh (+2 -1)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Chromium recently had an update which causes the Hoarder build to fail. This PR fixes the issue by specifying that Debian install Chromium and Chromium-common from the stable repo rather than the Security repo. After the container is built and when a user decides to update the system, Debian will handle this correctly by holding the packages back until it's dependencies are updated.

Fixes #719

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Anyone who installed Hoarder via the script prior to the Chromium package update may need to manually intervene to fix conflicts prior to updating the system (running the update script is fine). Recommend that they run:

apt autoremove chromium
apt update && apt install chromium/stable chromium-common/stable

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/723 **Author:** [@vhsdream](https://github.com/vhsdream) **Created:** 12/7/2024 **Status:** ✅ Merged **Merged:** 12/7/2024 **Merged by:** [@havardthom](https://github.com/havardthom) **Base:** `main` ← **Head:** `hoarder-fix` --- ### 📝 Commits (1) - [`7db93f4`](https://github.com/community-scripts/ProxmoxVE/commit/7db93f429f618ea1fddb8afdb50e22f6f54f9bf3) Fix Hoarder build failure by installing Chromium stable ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `install/hoarder-install.sh` (+2 -1) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description Chromium recently had an update which causes the Hoarder build to fail. This PR fixes the issue by specifying that Debian install Chromium and Chromium-common from the stable repo rather than the Security repo. After the container is built and when a user decides to update the system, Debian will handle this correctly by holding the packages back until it's dependencies are updated. Fixes #719 ## Type of change Please check the relevant option(s): - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [ ] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) Anyone who installed Hoarder via the script prior to the Chromium package update may need to manually intervene to fix conflicts prior to updating the system (running the update script is fine). Recommend that they run: ```bash apt autoremove chromium apt update && apt install chromium/stable chromium-common/stable ``` ## Related Pull Requests / Discussions If there are other pull requests or discussions related to this change, please link them here: - Related PR # --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 13:31:35 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#2854
No description provided.