starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 01:06:06 +03:00

[PR #717] [MERGED] Fix bugs in Komga update #2848

New issue

Closed

opened 2026-02-26 13:31:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:31:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/717
Author: @yry-dev
Created: 12/6/2024
Status: ✅ Merged
Merged: 12/6/2024
Merged by: @MickLesk

Base: main ← Head: main

📝 Commits (2)

6f49b48 Fix update script
58e4562 Update some bad update urls

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 ct/komga.sh (+3 -3)

📄 Description

Description

Fixes for the komga upgrade script.

Fixes #707

Type of change

Please check the relevant option(s):

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
Testing performed (I have tested my changes, ensuring everything works as expected)
Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Fix check for currently installed komga (earlier versions of the script assumed a naming convention of komga-version.jar but the final approved version dropped the version string from the jar)
Download URL was wrong for new komga versions (other github repors do indeed use v${RELEASE} in the url but not this project)
Moved the removing of the old version until AFTER we successfully downloaded a new one so that if we ever fail to update in the future at lease the service isn't completly hosed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/717 **Author:** [@yry-dev](https://github.com/yry-dev) **Created:** 12/6/2024 **Status:** ✅ Merged **Merged:** 12/6/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`6f49b48`](https://github.com/community-scripts/ProxmoxVE/commit/6f49b488370e50f9042b009ec6b4a1dc2cc7e42c) Fix update script - [`58e4562`](https://github.com/community-scripts/ProxmoxVE/commit/58e4562f17301a671881a4c8e72a86631286a24a) Update some bad update urls ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ct/komga.sh` (+3 -3) </details> ### 📄 Description ## Description Fixes for the komga upgrade script. Fixes #707 ## Type of change Please check the relevant option(s): - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [x] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) - Fix check for currently installed komga (earlier versions of the script assumed a naming convention of komga-version.jar but the final approved version dropped the version string from the jar) - Download URL was wrong for new komga versions (other github repors do indeed use v${RELEASE} in the url but not this project) - Moved the removing of the old version until AFTER we successfully downloaded a new one so that if we ever fail to update in the future at lease the service isn't completly hosed ![2024-12-06 11_41_11-proxmox - Proxmox Virtual Environment — Mozilla Firefox](https://github.com/user-attachments/assets/317cdd63-1d4d-40dc-906a-8f4ef6e533c6) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:31:34 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2848

No description provided.

Rows
Columns