starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 09:15:59 +03:00

[PR #491] [CLOSED] Use $BASH rather than $SHELL to check for Bash as active shell, instead of as default shell #2743

New issue

Closed

opened 2026-02-26 13:31:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:31:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/491
Author: @itsthejb
Created: 11/24/2024
Status: ❌ Closed

Base: main ← Head: bash-active-shell

📝 Commits (2)

f25bed5 Use $BASH rather than $SHELL to check for Bash as active shell
4cbcdc0 Update warning message

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 misc/build.func (+2 -2)

📄 Description

Description

To $BASH env var is set when Bash is the active shell. This is in contrast to $SHELL, which points to the user's default shell. For cases where the user's default shell isn't Bash, this allows for running the script using Bash, rather than requiring the user to change their default shell (using chsh) first.

Fixes #476

Type of change

Please check the relevant option(s):

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
Testing performed (I have tested my changes, ensuring everything works as expected)
Documentation updated (I have updated any relevant documentation)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/491 **Author:** [@itsthejb](https://github.com/itsthejb) **Created:** 11/24/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bash-active-shell` --- ### 📝 Commits (2) - [`f25bed5`](https://github.com/community-scripts/ProxmoxVE/commit/f25bed5ac597866cfd0efeae32ff053397aca527) Use $BASH rather than $SHELL to check for Bash as active shell - [`4cbcdc0`](https://github.com/community-scripts/ProxmoxVE/commit/4cbcdc0c241bc6b5e911d20f215452a04a76ec29) Update warning message ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+2 -2) </details> ### 📄 Description ## Description To `$BASH` env var is set when Bash is the active shell. This is in contrast to `$SHELL`, which points to the user's default shell. For cases where the user's default shell isn't Bash, this allows for running the script using Bash, rather than requiring the user to change their default shell (using `chsh`) first. Fixes #476 ## Type of change Please check the relevant option(s): - [ ] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [ ] Documentation updated (I have updated any relevant documentation) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:31:13 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 13:35:10 +03:00

[PR #2743] [MERGED] [Github Action] Update CHANGELOG.md #3946

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2743

No description provided.

Rows
Columns