starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 17:26:03 +03:00

[PR #317] [MERGED] Fix optional installs in Cockpit LXC #2679

New issue

Closed

opened 2026-02-26 13:31:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:31:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/317
Author: @havardthom
Created: 11/17/2024
Status: ✅ Merged
Merged: 11/18/2024
Merged by: @havardthom

Base: main ← Head: fix-cockpit

📝 Commits (1)

57f6f95 Fix optional installs in Cockpit LXC

📊 Changes

1 file changed (+9 additions, -12 deletions)

View changed files

📝 ct/cockpit.sh (+9 -12)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Switching optional installs to wget with curl and grep.
45Drives uses a build version in addition to release version in their releases, so we cannot use their github tag reliably: https://github.com/45Drives/cockpit-file-sharing/issues/115#issuecomment-2466461657

Fixes https://github.com/community-scripts/ProxmoxVE/issues/157

Type of change

Please check the relevant option(s):

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
Testing performed (I have tested my changes, ensuring everything works as expected)
Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

If there are other pull requests or discussions related to this change, please link them here:

Related PR #

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/317 **Author:** [@havardthom](https://github.com/havardthom) **Created:** 11/17/2024 **Status:** ✅ Merged **Merged:** 11/18/2024 **Merged by:** [@havardthom](https://github.com/havardthom) **Base:** `main` ← **Head:** `fix-cockpit` --- ### 📝 Commits (1) - [`57f6f95`](https://github.com/community-scripts/ProxmoxVE/commit/57f6f9547faffe437f3f07f2df6a24de0aa2d0ac) Fix optional installs in Cockpit LXC ### 📊 Changes **1 file changed** (+9 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `ct/cockpit.sh` (+9 -12) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description Switching optional installs to `wget` with `curl` and `grep`. 45Drives uses a build version in addition to release version in their releases, so we cannot use their github tag reliably: https://github.com/45Drives/cockpit-file-sharing/issues/115#issuecomment-2466461657 Fixes https://github.com/community-scripts/ProxmoxVE/issues/157 ## Type of change Please check the relevant option(s): - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [x] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) Provide any additional context or screenshots about the feature or fix here. ## Related Pull Requests / Discussions If there are other pull requests or discussions related to this change, please link them here: - Related PR # --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:31:00 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 13:35:02 +03:00

[PR #2679] [MERGED] [Github Action] Update CHANGELOG.md #3904

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2679

No description provided.

Rows
Columns