[PR #249] [MERGED] Add Option "check_storage" and "check_container_ressources" #2646

Closed
opened 2026-02-26 13:30:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/249
Author: @MickLesk
Created: 11/14/2024
Status: Merged
Merged: 11/15/2024
Merged by: @MickLesk

Base: mainHead: MickLesk-patch-1


📝 Commits (5)

  • d807dc7 Add Option "check_storage" and "check_container_ressources"
  • fecc532 Update misc/build.func
  • 5146ff6 Update misc/build.func
  • 8d54b87 Update misc/build.func
  • c78357b Final Version

📊 Changes

1 file changed (+33 additions, -0 deletions)

View changed files

📝 misc/build.func (+33 -0)

📄 Description

Description

1. added new function:
check_storage
=> This message already appears in some LXCs and has now been adopted as a basic function in build.func.

image

This can be added in the function update_script() area. (ct/lxc.sh).
It should be added subsequently for all CTs.
github.com/MickLesk/Proxmox_DEV@06ad30d94c/ct/nextpvr.sh (L57)


2. added new function:
check_container_ressources
=> if the ressources are not enough based on ct/script.sh the script exit with an output.
=> This message only appears if the RAM < var_ram or the cores < var_cpu of the CT

image

This can be added in the function update_script() area. (ct/lxc.sh).
It should be added subsequently for all CTs.
github.com/MickLesk/Proxmox_DEV@06ad30d94c/ct/nextpvr.sh (L58)


3. GENERAL:
The ct\lxc.sh scripts should now always look like this in the update area (keyword: harmonization)

function update_script() {
header_info
check_container_storage
check_container_resources

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Based to this issue:
https://github.com/community-scripts/ProxmoxVE/issues/236


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/249 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 11/14/2024 **Status:** ✅ Merged **Merged:** 11/15/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `MickLesk-patch-1` --- ### 📝 Commits (5) - [`d807dc7`](https://github.com/community-scripts/ProxmoxVE/commit/d807dc79d254d350a5a6fef99fafaa64dda3ad7a) Add Option "check_storage" and "check_container_ressources" - [`fecc532`](https://github.com/community-scripts/ProxmoxVE/commit/fecc5325c65b4404e45ed3085fc464e86428608f) Update misc/build.func - [`5146ff6`](https://github.com/community-scripts/ProxmoxVE/commit/5146ff63e7582f7ce3d332279a833d7221e60991) Update misc/build.func - [`8d54b87`](https://github.com/community-scripts/ProxmoxVE/commit/8d54b87146cd03f989b4a72178fb99dc189f1417) Update misc/build.func - [`c78357b`](https://github.com/community-scripts/ProxmoxVE/commit/c78357b69a044746928bc5da62584413515276e2) Final Version ### 📊 Changes **1 file changed** (+33 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `misc/build.func` (+33 -0) </details> ### 📄 Description ## Description **1. added new function:** check_storage => This message already appears in some LXCs and has now been adopted as a basic function in build.func. <img width="769" alt="image" src="https://github.com/user-attachments/assets/54c6df81-3b2e-4be9-b7ff-14dc38484216"> This can be added in the function update_script() area. (ct/lxc.sh). It should be added subsequently for all CTs. https://github.com/MickLesk/Proxmox_DEV/blob/06ad30d94cc82cd793d6ac4cbcf1077a1e2f5994/ct/nextpvr.sh#L57 --- **2. added new function:** check_container_ressources => if the ressources are not enough based on ct/script.sh the script exit with an output. => This message only appears if the RAM < var_ram or the cores < var_cpu of the CT <img width="735" alt="image" src="https://github.com/user-attachments/assets/bf63ab3e-230f-46d3-9511-064d2003b19e"> This can be added in the function update_script() area. (ct/lxc.sh). It should be added subsequently for all CTs. https://github.com/MickLesk/Proxmox_DEV/blob/06ad30d94cc82cd793d6ac4cbcf1077a1e2f5994/ct/nextpvr.sh#L58 --- **3. GENERAL:** The ct\lxc.sh scripts should now always look like this in the update area (keyword: harmonization) ```bash function update_script() { header_info check_container_storage check_container_resources ``` --- ## Type of change Please check the relevant option(s): - [ ] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) - [x] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) - [ ] Documentation updated (I have updated any relevant documentation) Based to this issue: https://github.com/community-scripts/ProxmoxVE/issues/236 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 13:30:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#2646
No description provided.