starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 17:26:03 +03:00

[PR #235] [MERGED] Update pihole-install.sh #2641

New issue

Closed

opened 2026-02-26 13:30:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:30:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/235
Author: @davalanche
Created: 11/13/2024
Status: ✅ Merged
Merged: 11/14/2024
Merged by: @havardthom

Base: main ← Head: pihole

📝 Commits (3)

da6ff6d Update pihole-install.sh
134dc1a Update pihole.json
7b3f26e Update install/pihole-install.sh

📊 Changes

2 files changed (+35 additions, -5 deletions)

View changed files

📝 install/pihole-install.sh (+29 -3)
📝 json/pihole.json (+6 -2)

📄 Description

Description

Added the option to configure Unbound as a forwarding DNS server (using DNS-over-TLS (DoT)).
Simplified the Unbound configuration. The root hints file is actually provided by the dns-root-data package so there is no need to explicitly define it (via the root-hints configuration directive) and wget it. Also, there was no mechanism to update the file after the initial fetch - this will now done by the package manager.
Fix: Unbound (127.0.0.1#5335) would not become active until a configuration change was made and saved or the application was updated. These are the only times (other than during install) that /etc/dnsmasq.d/01-pihole.conf is synced with /etc/pihole/setupVars.conf. Updated the install script to swap out the dns server in /etc/dnsmasq.d/01-pihole.conf similar to /etc/pihole/setupVars.conf. Delete 8.8.4.4 in both files as opposed to commenting it out as the commented out line would never be recycled.

Type of change

Please check the relevant option(s):

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
Testing performed (I have tested my changes, ensuring everything works as expected)
Documentation updated (I have updated any relevant documentation)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/235 **Author:** [@davalanche](https://github.com/davalanche) **Created:** 11/13/2024 **Status:** ✅ Merged **Merged:** 11/14/2024 **Merged by:** [@havardthom](https://github.com/havardthom) **Base:** `main` ← **Head:** `pihole` --- ### 📝 Commits (3) - [`da6ff6d`](https://github.com/community-scripts/ProxmoxVE/commit/da6ff6d6605bd2f46870a1855f23eb924d5612c4) Update pihole-install.sh - [`134dc1a`](https://github.com/community-scripts/ProxmoxVE/commit/134dc1a8cb5835b6e4eb672170440127b4fe12f7) Update pihole.json - [`7b3f26e`](https://github.com/community-scripts/ProxmoxVE/commit/7b3f26ea9b66478ffd7f200c891e9efa9a4d0c18) Update install/pihole-install.sh ### 📊 Changes **2 files changed** (+35 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `install/pihole-install.sh` (+29 -3) 📝 `json/pihole.json` (+6 -2) </details> ### 📄 Description ## Description * Added the option to configure Unbound as a forwarding DNS server (using DNS-over-TLS (DoT)). * Simplified the Unbound configuration. The root hints file is actually provided by the dns-root-data package so there is no need to explicitly define it (via the root-hints configuration directive) and wget it. Also, there was no mechanism to update the file after the initial fetch - this will now done by the package manager. * Fix: Unbound (127.0.0.1#5335) would not become active until a configuration change was made and saved or the application was updated. These are the only times (other than during install) that /etc/dnsmasq.d/01-pihole.conf is synced with /etc/pihole/setupVars.conf. Updated the install script to swap out the dns server in /etc/dnsmasq.d/01-pihole.conf similar to /etc/pihole/setupVars.conf. Delete 8.8.4.4 in both files as opposed to commenting it out as the commented out line would never be recycled. ## Type of change Please check the relevant option(s): - [X] Bug fix (non-breaking change that resolves an issue) - [X] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [X] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [X] Testing performed (I have tested my changes, ensuring everything works as expected) - [X] Documentation updated (I have updated any relevant documentation) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:30:53 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 13:34:57 +03:00

[PR #2646] [MERGED] Kimai: add local.yaml & fix path permissions #3883

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2641

No description provided.

Rows
Columns