[PR #219] [MERGED] Fixing Front end issues related to image loading and SEO #2631

Closed
opened 2026-02-26 13:30:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/219
Author: @BramSuurdje
Created: 11/13/2024
Status: Merged
Merged: 11/13/2024
Merged by: @MickLesk

Base: mainHead: main


📝 Commits (10+)

  • 96046f2 Update mariadb.json
  • a027259 Update vaultwarden.json
  • 980c4e8 Update vaultwarden.json
  • e1efaf3 Update keycloak.json
  • fc5128f Update json/keycloak.json
  • b916f8d Update mariadb.json
  • b789792 Add canonical link to layout for improved SEO and page indexing
  • bb590c6 Fix image source fallback for script logos to use a consistent relative path
  • 3f21155 Merge branch 'main' of github.com:BramSuurdje/ProxmoxVE
  • 3952c5d Merge branch 'community-scripts:main' into main

📊 Changes

5 files changed (+22 additions, -9 deletions)

View changed files

📝 frontend/src/app/layout.tsx (+1 -0)
📝 frontend/src/app/scripts/_components/ScriptAccordion.tsx (+3 -2)
📝 frontend/src/app/scripts/_components/ScriptInfoBlocks.tsx (+11 -3)
📝 frontend/src/app/scripts/_components/ScriptItem.tsx (+4 -2)
📝 frontend/src/components/CommandMenu.tsx (+3 -2)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

This PR fixes isses #205 and #204

Fixes # (issue)

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

If there are other pull requests or discussions related to this change, please link them here:


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/219 **Author:** [@BramSuurdje](https://github.com/BramSuurdje) **Created:** 11/13/2024 **Status:** ✅ Merged **Merged:** 11/13/2024 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`96046f2`](https://github.com/community-scripts/ProxmoxVE/commit/96046f2121433828215dfc4eba4499a4a07a508e) Update mariadb.json - [`a027259`](https://github.com/community-scripts/ProxmoxVE/commit/a027259c1877a80cc0bf00681baa845e960d89f5) Update vaultwarden.json - [`980c4e8`](https://github.com/community-scripts/ProxmoxVE/commit/980c4e84848f7aeab6228296e5d9ff094c7384c9) Update vaultwarden.json - [`e1efaf3`](https://github.com/community-scripts/ProxmoxVE/commit/e1efaf3cee949d3f3b3a001657f525d2fd0e5b4d) Update keycloak.json - [`fc5128f`](https://github.com/community-scripts/ProxmoxVE/commit/fc5128fbe3d2f23ef88ddced80ffe8680ef329ab) Update json/keycloak.json - [`b916f8d`](https://github.com/community-scripts/ProxmoxVE/commit/b916f8dc873f34d0804fefa6a93fad12e5114d03) Update mariadb.json - [`b789792`](https://github.com/community-scripts/ProxmoxVE/commit/b78979260f7568351ca9df07c7330174173f4551) Add canonical link to layout for improved SEO and page indexing - [`bb590c6`](https://github.com/community-scripts/ProxmoxVE/commit/bb590c697e16738fd3885d85bec8d8d264d68cb2) Fix image source fallback for script logos to use a consistent relative path - [`3f21155`](https://github.com/community-scripts/ProxmoxVE/commit/3f21155d53e093077e63533899a5484d449e1e16) Merge branch 'main' of github.com:BramSuurdje/ProxmoxVE - [`3952c5d`](https://github.com/community-scripts/ProxmoxVE/commit/3952c5dfac9272bf6ae2f8435148c6ef34e4ff46) Merge branch 'community-scripts:main' into main ### 📊 Changes **5 files changed** (+22 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/app/layout.tsx` (+1 -0) 📝 `frontend/src/app/scripts/_components/ScriptAccordion.tsx` (+3 -2) 📝 `frontend/src/app/scripts/_components/ScriptInfoBlocks.tsx` (+11 -3) 📝 `frontend/src/app/scripts/_components/ScriptItem.tsx` (+4 -2) 📝 `frontend/src/components/CommandMenu.tsx` (+3 -2) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description This PR fixes isses #205 and #204 Fixes # (issue) ## Type of change Please check the relevant option(s): - [x] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [ ] Testing performed (I have tested my changes, ensuring everything works as expected) - [ ] Documentation updated (I have updated any relevant documentation) ## Additional Information (optional) Provide any additional context or screenshots about the feature or fix here. ## Related Pull Requests / Discussions If there are other pull requests or discussions related to this change, please link them here: - Related PR #205 and #204 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 13:30:51 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ProxmoxVE#2631
No description provided.