starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 09:15:59 +03:00

[PR #120] [MERGED] Adding a scrollbar to the sidebar for better navigation. #2602

New issue

Closed

opened 2026-02-26 13:30:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 13:30:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/120
Author: @BramSuurdje
Created: 11/7/2024
Status: ✅ Merged
Merged: 11/7/2024
Merged by: @havardthom

Base: main ← Head: main

📝 Commits (4)

ada1a53 manually set basePath in next.config.mjs
21c4723 Fix: add getDisplayValueFromType formatting in InstallCommand instead of displaying raw type
bdb448f Refactor ScriptAccordion to improve layout and scroll handling
d3ac388 Merge branch 'community-scripts:main' into main

📊 Changes

3 files changed (+28 additions, -19 deletions)

View changed files

📝 frontend/src/app/scripts/_components/ScriptAccordion.tsx (+4 -7)
📝 frontend/src/app/scripts/_components/ScriptItems/InstallCommand.tsx (+15 -9)
📝 frontend/src/styles/globals.css (+9 -3)

📄 Description

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

This PR aims to improve the navigation around the scripts page by adding a scrollbar to the sidebar. this had been requested in a discussion as had been on my mind for a longer period of time.

This PR also fixes an issue with the install methods component where it would show the raw type instead of the formatted type.

Fixes # (issue)

Type of change

Please check the relevant option(s):

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
Testing performed (I have tested my changes, ensuring everything works as expected)

If there are other pull requests or discussions related to this change, please link them here:

Related Discussion: #113

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/120 **Author:** [@BramSuurdje](https://github.com/BramSuurdje) **Created:** 11/7/2024 **Status:** ✅ Merged **Merged:** 11/7/2024 **Merged by:** [@havardthom](https://github.com/havardthom) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`ada1a53`](https://github.com/community-scripts/ProxmoxVE/commit/ada1a537e5ad135766835f99b0803c9bd9ec3701) manually set basePath in `next.config.mjs` - [`21c4723`](https://github.com/community-scripts/ProxmoxVE/commit/21c472330d4899c83e7915acf9e660a74dbe617c) Fix: add getDisplayValueFromType formatting in InstallCommand instead of displaying raw type - [`bdb448f`](https://github.com/community-scripts/ProxmoxVE/commit/bdb448ff1378f59d0e819ec0a66e79f182324146) Refactor ScriptAccordion to improve layout and scroll handling - [`d3ac388`](https://github.com/community-scripts/ProxmoxVE/commit/d3ac38821de710400eb4a32c5db631cedaa0568e) Merge branch 'community-scripts:main' into main ### 📊 Changes **3 files changed** (+28 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/app/scripts/_components/ScriptAccordion.tsx` (+4 -7) 📝 `frontend/src/app/scripts/_components/ScriptItems/InstallCommand.tsx` (+15 -9) 📝 `frontend/src/styles/globals.css` (+9 -3) </details> ### 📄 Description > [!NOTE] > We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged. ## Description This PR aims to improve the navigation around the scripts page by adding a scrollbar to the sidebar. this had been requested in a discussion as had been on my mind for a longer period of time. This PR also fixes an issue with the install methods component where it would show the raw type instead of the formatted type. Fixes # (issue) ## Type of change Please check the relevant option(s): - [x] Bug fix (non-breaking change that resolves an issue) - [x] New feature (non-breaking change that adds functionality) ## Prerequisites The following efforts must be made for the PR to be considered. Please check when completed: - [x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [x] Testing performed (I have tested my changes, ensuring everything works as expected) ## Related Pull Requests / Discussions If there are other pull requests or discussions related to this change, please link them here: - Related Discussion: #113 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 13:30:45 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 13:34:53 +03:00

[PR #2602] [MERGED] Website: Change Info for PiHole Password #3856

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2602

No description provided.

Rows
Columns