starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 01:06:06 +03:00

[GH-ISSUE #10740] Booklore env variables are incorrectly named #2309

New issue

Closed

opened 2026-02-26 12:52:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:52:00 +03:00

Owner

Originally created by @johanngrobe on GitHub (Jan 12, 2026).
Original GitHub issue: https://github.com/community-scripts/ProxmoxVE/issues/10740

Originally assigned to: @vhsdream on GitHub.

✅ Have you read and understood the above guidelines?

yes

🔎 Did you run the script with verbose mode enabled?

No (this issue will likely be closed automatically)

📜 What is the name of the script you are using?

Booklore

📂 What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/booklore.sh)"

⚙️ What settings are you using?

Default Settings
Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

📈 Which Proxmox version are you on?

9.1.4

📝 Provide a clear and concise description of the issue.

I came across a closed issue about the bookdrop feature in booklore (https://github.com/community-scripts/ProxmoxVE/issues/7499). I was not able to make it work. So I finally opened an issue in the booklore repo
(https://github.com/booklore-app/booklore/issues/2240#issuecomment-3736399735). With their help I was able to make the bookdrop feature work.

After all this made me curious and I some other env variables from the booklore install script. My booklore instance was not using /opt/booklore_storage/data but instead /app/data. The env variables were clearly not overwriting the config from booklore.

This is the booklore config (https://github.com/booklore-app/booklore/blob/master/booklore-api/src/main/resources/application.yaml):

app:
  path-config: '/app/data'
  bookdrop-folder: '/bookdrop'

These are the env variables set by the helper script:

BOOKLORE_DATA_PATH=/opt/booklore_storage/data
BOOKLORE_BOOKS_PATH=/opt/booklore_storage/books
BOOKLORE_BOOKDROP_PATH=/opt/booklore_storage/bookdrop

This would be correct according to the config.

APP_PATH_CONFIG=/opt/booklore_storage/data
APP_BOOKDROP_FOLDER=/opt/booklore_storage/bookdrop

I don't have a clue how BOOKLORE_BOOKS_PATHis being used. To me it seems like this env variable has no purpose since there is no such setting within the booklore config. The only use case I can come up with is docker. But that is not of much interest here.

🔄 Steps to reproduce the issue.

just install booklore.

❌ Paste the full error output (if available).

no error log.

🖼️ Additional context (optional).

No response

Originally created by @johanngrobe on GitHub (Jan 12, 2026). Original GitHub issue: https://github.com/community-scripts/ProxmoxVE/issues/10740 Originally assigned to: @vhsdream on GitHub. ### ✅ Have you read and understood the above guidelines? yes ### 🔎 Did you run the script with verbose mode enabled? No (this issue will likely be closed automatically) ### 📜 What is the name of the script you are using? Booklore ### 📂 What was the exact command used to execute the script? bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/booklore.sh)" ### ⚙️ What settings are you using? - [x] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 📈 Which Proxmox version are you on? 9.1.4 ### 📝 Provide a clear and concise description of the issue. I came across a closed issue about the bookdrop feature in booklore (https://github.com/community-scripts/ProxmoxVE/issues/7499). I was not able to make it work. So I finally opened an issue in the booklore repo (https://github.com/booklore-app/booklore/issues/2240#issuecomment-3736399735). With their help I was able to make the bookdrop feature work. After all this made me curious and I some other env variables from the booklore install script. My booklore instance was not using `/opt/booklore_storage/data` but instead `/app/data`. The env variables were clearly not overwriting the config from booklore. This is the booklore config (https://github.com/booklore-app/booklore/blob/master/booklore-api/src/main/resources/application.yaml): ``` app: path-config: '/app/data' bookdrop-folder: '/bookdrop' ``` These are the env variables set by the helper script: ``` BOOKLORE_DATA_PATH=/opt/booklore_storage/data BOOKLORE_BOOKS_PATH=/opt/booklore_storage/books BOOKLORE_BOOKDROP_PATH=/opt/booklore_storage/bookdrop ``` This would be correct according to the config. ``` APP_PATH_CONFIG=/opt/booklore_storage/data APP_BOOKDROP_FOLDER=/opt/booklore_storage/bookdrop ``` I don't have a clue how `BOOKLORE_BOOKS_PATH`is being used. To me it seems like this env variable has no purpose since there is no such setting within the booklore config. The only use case I can come up with is docker. But that is not of much interest here. ### 🔄 Steps to reproduce the issue. just install booklore. ### ❌ Paste the full error output (if available). no error log. ### 🖼️ Additional context (optional). _No response_

kerem

2026-02-26 12:52:00 +03:00

closed this issue
added the
bug

refactor
labels

kerem referenced this issue

2026-02-26 13:34:20 +03:00

[PR #2309] [MERGED] [Github Action] Update CHANGELOG.md #3683

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2309

No description provided.

Rows
Columns