starred/ProxmoxVE

Fork 0

mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-04-25 17:26:03 +03:00

[GH-ISSUE #9853] Defaults system: Support to add tags from installer script #2146

New issue

Closed

opened 2026-02-26 12:51:27 +03:00 by kerem · 4 comments

kerem commented

2026-02-26 12:51:27 +03:00

Owner

Originally created by @Gregor-zbjk on GitHub (Dec 10, 2025).
Original GitHub issue: https://github.com/community-scripts/ProxmoxVE/issues/9853

🌟 Briefly describe the feature

Add tags from installer script to Defaults

📝 Detailed description

I noticed that when I run the installer with option "User Defaults" only the tags defined in the defaults file is added instead of "community-scripts" & "cloud" (e.g. Nextcloudpi).. in the old config file system this was possible.

I would like to see an option to transfer the tags from the installation script to the defaults file
e.g.

var_tags=dev,DEFAULT

DEFAULT=Default Tags of the installer script (e.g. Nextcloudpi: “community-scripts” & “cloud”)

This would be following Tags as result:
dev, community-scripts, cloud

💡 Why is this useful?

This would allow the original installer script tags to be retained and new ones, e.g. “dev”, to be added... thus allowing better differentiation in Proxmox

Originally created by @Gregor-zbjk on GitHub (Dec 10, 2025). Original GitHub issue: https://github.com/community-scripts/ProxmoxVE/issues/9853 ### 🌟 Briefly describe the feature Add tags from installer script to Defaults ### 📝 Detailed description I noticed that when I run the installer with option "User Defaults" only the tags defined in the defaults file is added instead of "community-scripts" & "cloud" (e.g. Nextcloudpi).. in the old config file system this was possible. I would like to see an option to transfer the tags from the installation script to the defaults file e.g. `var_tags=dev,DEFAULT` DEFAULT=Default Tags of the installer script (e.g. Nextcloudpi: “community-scripts” & “cloud”) This would be following Tags as result: `dev, community-scripts, cloud` ### 💡 Why is this useful? This would allow the original installer script tags to be retained and new ones, e.g. “dev”, to be added... thus allowing better differentiation in Proxmox

kerem

2026-02-26 12:51:27 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-02-26 12:51:29 +03:00

Author

Owner

@MickLesk commented on GitHub (Dec 10, 2025):

Honestly, for what? Either you write all the tags in, or none at all. In my opinion, a default is unnecessary, given that maybe 0.005% of users would ever use it, if that.

Basically, you can also use the Default.vars or the $App.vars.

@MickLesk commented on GitHub (Dec 10, 2025): Honestly, for what? Either you write all the tags in, or none at all. In my opinion, a default is unnecessary, given that maybe 0.005% of users would ever use it, if that. Basically, you can also use the Default.vars or the $App.vars.

kerem commented

2026-02-26 12:51:29 +03:00

Author

Owner

@Gregor-zbjk commented on GitHub (Jan 2, 2026):

@MickLesk Thanks for the quick response!

The issue occurs specifically with community nodes that use npm packages or spawn subprocesses. While the LXC container itself runs privileged, n8n as an application benefits from running as a dedicated user for several reasons:

Problems we've encountered:

npm permission errors: Some community nodes fail to install dependencies when n8n runs as root
Puppeteer/Chrome: Browser automation nodes throw "Running as root without --no-sandbox is not supported" errors
File ownership issues: Workflows and credentials get created with root ownership, causing permission conflicts

Real-world example:

Failed to launch browser: Running as root without --no-sandbox is not supported

This is a hard-coded Chrome security restriction that can't be bypassed without unsafe flags.

Industry standard:

Most Node.js applications (including n8n's official documentation) recommend running as a non-root user for security and compatibility reasons.

Happy to provide test results or adjust the approach if you have concerns about specific aspects!

@Gregor-zbjk commented on GitHub (Jan 2, 2026): @MickLesk Thanks for the quick response! The issue occurs specifically with **community nodes** that use npm packages or spawn subprocesses. While the LXC container itself runs privileged, n8n as an application benefits from running as a dedicated user for several reasons: ### Problems we've encountered: 1. **npm permission errors**: Some community nodes fail to install dependencies when n8n runs as root 2. **Puppeteer/Chrome**: Browser automation nodes throw "Running as root without --no-sandbox is not supported" errors 3. **File ownership issues**: Workflows and credentials get created with root ownership, causing permission conflicts ### Real-world example: ``` Failed to launch browser: Running as root without --no-sandbox is not supported ``` This is a hard-coded Chrome security restriction that can't be bypassed without unsafe flags. ### Industry standard: Most Node.js applications (including n8n's official documentation) recommend running as a non-root user for security and compatibility reasons. Happy to provide test results or adjust the approach if you have concerns about specific aspects!

kerem commented

2026-02-26 12:51:29 +03:00

Author

Owner

@MickLesk commented on GitHub (Jan 2, 2026):

What the hell do tags have to do with this AI text? It should better you read your First Post and my answer and dont flame complete other Messages

@MickLesk commented on GitHub (Jan 2, 2026): What the hell do tags have to do with this AI text? It should better you read your First Post and my answer and dont flame complete other Messages

kerem commented

2026-02-26 12:51:29 +03:00

Author

Owner

@Gregor-zbjk commented on GitHub (Jan 2, 2026):

Sorry was the wrong PR

@Gregor-zbjk commented on GitHub (Jan 2, 2026): Sorry was the wrong PR

kerem referenced this issue

2026-02-26 13:33:56 +03:00

[PR #2147] [MERGED] Fix: Zerotier-One fixed missing dependency #3568

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ProxmoxVE#2146

No description provided.

Rows
Columns