[PR #481] [MERGED] fix: resolve server from DB for SSH when client sends no ssh_key_path (fixes #466) #477

New issue

Closed

opened 2026-02-26 12:41:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:41:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/481
Author: @michelroegl-brunner
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @michelroegl-brunner

Base: main ← Head: fix/466

📝 Commits (1)

e1d270d fix: resolve server from DB for SSH when client sends no ssh_key_path (fixes #466)

📊 Changes

1 file changed (+27 additions, -5 deletions)

View changed files

📝 server.js (+27 -5)

📄 Description

Fixes #466

When opening Shell or running Update over SSH with key auth, the client sends a server object built from script data (id, ip, user, auth_type, ssh_key, etc.) but without ssh_key_path (server-side path). The SSH execution layer requires ssh_key_path for key auth, so it threw "SSH key file not found".

This PR adds resolveServerForSSH(server) in the WebSocket handler: when the incoming server has id but key auth without a valid ssh_key_path, we load the full server from the database and use it for the SSH call. All start flows (clone, backup, update, shell, script) now receive the resolved server.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/481 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/466` --- ### 📝 Commits (1) - [`e1d270d`](https://github.com/community-scripts/ProxmoxVE-Local/commit/e1d270d52ce9d17126e89deb79e65a61d2b05400) fix: resolve server from DB for SSH when client sends no ssh_key_path (fixes #466) ### 📊 Changes **1 file changed** (+27 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `server.js` (+27 -5) </details> ### 📄 Description Fixes #466 When opening Shell or running Update over SSH with key auth, the client sends a server object built from script data (id, ip, user, auth_type, ssh_key, etc.) but without `ssh_key_path` (server-side path). The SSH execution layer requires `ssh_key_path` for key auth, so it threw "SSH key file not found". This PR adds `resolveServerForSSH(server)` in the WebSocket handler: when the incoming server has `id` but key auth without a valid `ssh_key_path`, we load the full server from the database and use it for the SSH call. All start flows (clone, backup, update, shell, script) now receive the resolved server. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>