[PR #474] [MERGED] fix: allow domain names for APT Cacher in container creation UI #469

New issue

Closed

opened 2026-02-26 12:41:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:41:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/474
Author: @michelroegl-brunner
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @michelroegl-brunner

Base: main ← Head: fix/404

📝 Commits (1)

9e6154b fix: allow domain names for APT Cacher in container creation UI

📊 Changes

1 file changed (+15 additions, -4 deletions)

View changed files

📝 src/app/_components/ConfigurationModal.tsx (+15 -4)

📄 Description

When creating a new container from the UI, the APT Cacher field required an IP address and showed "Invalid IPv4 address" for domain names (e.g. apt-cacher.internal). The classic script flow already accepted hostnames.

Changes:

Add validateHostname and validateAptCacherAddress (accepts IPv4 or hostname)
Use new validator for var_apt_cacher_ip; error message: "Invalid IPv4 address or hostname"
Label: "APT Cacher host or IP"; placeholder: "192.168.1.10 or apt-cacher.internal"

Fixes #404

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/474 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/404` --- ### 📝 Commits (1) - [`9e6154b`](https://github.com/community-scripts/ProxmoxVE-Local/commit/9e6154b0de4a83c9dbe835b27dc4f87ccb046577) fix: allow domain names for APT Cacher in container creation UI ### 📊 Changes **1 file changed** (+15 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/ConfigurationModal.tsx` (+15 -4) </details> ### 📄 Description When creating a new container from the UI, the APT Cacher field required an IP address and showed "Invalid IPv4 address" for domain names (e.g. `apt-cacher.internal`). The classic script flow already accepted hostnames. **Changes:** - Add `validateHostname` and `validateAptCacherAddress` (accepts IPv4 or hostname) - Use new validator for `var_apt_cacher_ip`; error message: "Invalid IPv4 address or hostname" - Label: "APT Cacher host or IP"; placeholder: "192.168.1.10 or apt-cacher.internal" Fixes #404 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>