[PR #440] [MERGED] Improve Node.js upgrade and service recovery in update.sh #443

New issue

Closed

opened 2026-02-26 12:41:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:41:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/440
Author: @MickLesk
Created: 1/13/2026
Status: ✅ Merged
Merged: 1/13/2026
Merged by: @MickLesk

Base: main ← Head: fixes_update

📝 Commits (1)

9ead3a2 Improve Node.js upgrade and service recovery in update.sh

📊 Changes

1 file changed (+47 additions, -7 deletions)

View changed files

📝 update.sh (+47 -7)

📄 Description

✍️ Description

Enhances the Node.js upgrade process by handling both .list and .sources files, updating the apt cache, and adding error handling for download and install failures. Introduces a function to re-enable and start the systemd service on failure to prevent user lockout, and ensures this is called during rollback and upgrade errors. Also refines Node.js version checks and build environment setup.

Fixes: #439 #437 #429

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

Screenshot for frontend Change

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/440 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 1/13/2026 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `fixes_update` --- ### 📝 Commits (1) - [`9ead3a2`](https://github.com/community-scripts/ProxmoxVE-Local/commit/9ead3a2a32bb4e6ea21a243b764e647656b02a14) Improve Node.js upgrade and service recovery in update.sh ### 📊 Changes **1 file changed** (+47 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `update.sh` (+47 -7) </details> ### 📄 Description  ## ✍️ Description Enhances the Node.js upgrade process by handling both .list and .sources files, updating the apt cache, and adding error handling for download and install failures. Introduces a function to re-enable and start the systemd service on failure to prevent user lockout, and ensures this is called during rollback and upgrade errors. Also refines Node.js version checks and build environment setup. ## 🔗 Related PR / Issue Fixes: #439 #437 #429 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [ ] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. ## Screenshot for frontend Change --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>