[PR #427] [MERGED] fix: pct create fails with malformed arguments (#423) #436

New issue

Closed

opened 2026-02-26 12:41:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:41:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/427
Author: @MickLesk
Created: 1/7/2026
Status: ✅ Merged
Merged: 1/7/2026
Merged by: @MickLesk

Base: main ← Head: fix_db_initialization

📝 Commits (1)

634c3fb fix: pct create fails with malformed arguments (#423)

📊 Changes

3 files changed (+39 additions, -7 deletions)

View changed files

📝 scripts/core/build.func (+13 -7)
📝 src/server/db.js (+13 -0)
📝 src/server/db.ts (+13 -0)

📄 Description

✍️ Description

Fix NS/MTU/MAC/VLAN/SD variables missing proper prefixes in base_settings() Variables were passed as raw values instead of formatted pct options (e.g., '192.168.1.1' instead of '-nameserver=192.168.1.1')
Strip spaces from nameserver values to prevent 'too many arguments' error Multiple DNS servers must be comma-separated without spaces
Auto-create database directory before Prisma initialization Fixes 'Cannot open database because directory does not exist' error for manual Git installations

Fixes: #422
Fixes: #423

✅ Prerequisites (X in brackets)

Self-review completed – Code follows project standards.
Tested thoroughly – Changes work as expected.
No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

Screenshot for frontend Change

🛠️ Type of Change (X in brackets)

🐞 Bug fix – Resolves an issue without breaking functionality.
✨ New feature – Adds new, non-breaking functionality.
💥 Breaking change – Alters existing functionality in a way that may require updates.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/427 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 1/7/2026 **Status:** ✅ Merged **Merged:** 1/7/2026 **Merged by:** [@MickLesk](https://github.com/MickLesk) **Base:** `main` ← **Head:** `fix_db_initialization` --- ### 📝 Commits (1) - [`634c3fb`](https://github.com/community-scripts/ProxmoxVE-Local/commit/634c3fbb3efde34079d3afe2a1261c153e138fd8) fix: pct create fails with malformed arguments (#423) ### 📊 Changes **3 files changed** (+39 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `scripts/core/build.func` (+13 -7) 📝 `src/server/db.js` (+13 -0) 📝 `src/server/db.ts` (+13 -0) </details> ### 📄 Description  ## ✍️ Description - Fix NS/MTU/MAC/VLAN/SD variables missing proper prefixes in base_settings() Variables were passed as raw values instead of formatted pct options (e.g., '192.168.1.1' instead of '-nameserver=192.168.1.1') - Strip spaces from nameserver values to prevent 'too many arguments' error Multiple DNS servers must be comma-separated without spaces - Auto-create database directory before Prisma initialization Fixes 'Cannot open database because directory does not exist' error for manual Git installations ## 🔗 Related PR / Issue Fixes: #422 Fixes: #423 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. ## Screenshot for frontend Change --- ## 🛠️ Type of Change (**X** in brackets) - [x] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>