[PR #358] [MERGED] fix: Add dynamic text to container control loading modal #386

New issue

Closed

opened 2026-02-26 12:41:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:41:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/358
Author: @michelroegl-brunner
Created: 11/29/2025
Status: ✅ Merged
Merged: 11/29/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/357_356

📝 Commits (3)

84c0204 Fix a false detection as a VM when it is a LXC
93d7842 feat: implement batch container type detection for performance optimization
5564ae0 fix: add dynamic text to container control loading modal

📊 Changes

6 files changed (+194 additions, -22 deletions)

View changed files

📝 package-lock.json (+4 -3)
📝 package.json (+4 -3)
📝 src/app/_components/InstalledScriptsTab.tsx (+3 -1)
📝 src/app/_components/LoadingModal.tsx (+6 -1)
📝 src/server/api/routers/installedScripts.ts (+173 -12)
📝 src/server/database-prisma.ts (+4 -2)

📄 Description

Description

This PR adds dynamic text to the container control loading modal to show what action is being performed and the container type.

Changes

Updated LoadingModal component to display the action prop text below the spinner
Updated handleStartStop function to include container type (LXC/VM) in the action text
Users now see "Starting LXC...", "Starting VM...", "Stopping LXC...", or "Stopping VM..." based on the action and container type

Fixes the user experience issue where the loading modal only showed a spinner without clear indication of what action was being performed.

Testing

Tested starting/stopping LXC containers - shows "Starting LXC..." / "Stopping LXC..."
Tested starting/stopping VMs - shows "Starting VM..." / "Stopping VM..."

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/358 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/29/2025 **Status:** ✅ Merged **Merged:** 11/29/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/357_356` --- ### 📝 Commits (3) - [`84c0204`](https://github.com/community-scripts/ProxmoxVE-Local/commit/84c02048bcdac532c72a90cfcfa13d3b5ecc7170) Fix a false detection as a VM when it is a LXC - [`93d7842`](https://github.com/community-scripts/ProxmoxVE-Local/commit/93d7842f6ca2879cbe83fd82290c7d4f5a5c4447) feat: implement batch container type detection for performance optimization - [`5564ae0`](https://github.com/community-scripts/ProxmoxVE-Local/commit/5564ae0393590c0c04dabedbf3fcc45fc5b9a124) fix: add dynamic text to container control loading modal ### 📊 Changes **6 files changed** (+194 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+4 -3) 📝 `package.json` (+4 -3) 📝 `src/app/_components/InstalledScriptsTab.tsx` (+3 -1) 📝 `src/app/_components/LoadingModal.tsx` (+6 -1) 📝 `src/server/api/routers/installedScripts.ts` (+173 -12) 📝 `src/server/database-prisma.ts` (+4 -2) </details> ### 📄 Description ## Description This PR adds dynamic text to the container control loading modal to show what action is being performed and the container type. ## Changes - Updated LoadingModal component to display the action prop text below the spinner - Updated handleStartStop function to include container type (LXC/VM) in the action text - Users now see "Starting LXC...", "Starting VM...", "Stopping LXC...", or "Stopping VM..." based on the action and container type ## Related Issues Fixes the user experience issue where the loading modal only showed a spinner without clear indication of what action was being performed. ## Testing - Tested starting/stopping LXC containers - shows "Starting LXC..." / "Stopping LXC..." - Tested starting/stopping VMs - shows "Starting VM..." / "Stopping VM..." --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>