[PR #303] [MERGED] fix: Add 'Delete only from DB' option for duplicate detected scripts #344

New issue

Closed

opened 2026-02-26 12:41:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:41:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/303
Author: @michelroegl-brunner
Created: 11/10/2025
Status: ✅ Merged
Merged: 11/10/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/289

📝 Commits (1)

b192c46 fix: Add 'Delete only from DB' option for duplicate detected scripts

📊 Changes

1 file changed (+28 additions, -3 deletions)

View changed files

📝 src/app/_components/InstalledScriptsTab.tsx (+28 -3)

📄 Description

Problem

Users can have duplicate detected script entries (same container_id and server_id) in the database. Currently, for SSH scripts with container_id, the only option is "Destroy" which destroys the actual container. Users need a way to delete just the database record to clean up duplicates without destroying the host/container.

Solution

Add a "Delete only from DB" option in the Actions dropdown menu for detected scripts (SSH scripts with container_id) that:

Only deletes the database record
Does NOT destroy the container
Uses a clear confirmation modal to distinguish it from "Destroy"

Changes

Added "Delete only from DB" menu item in Actions dropdown for SSH scripts with container_id
Placed option after "Destroy" with separator to distinguish from destructive action
Updated handleDeleteScript to use confirmation modal for SSH scripts
Modal clearly states it only deletes database record, container remains intact
Allows users to clean up duplicate script entries without destroying containers

Testing

Verify Delete only removes the database record
Verify Destroy still works as before (destroys container + deletes record)
Verify duplicate scripts can be cleaned up without affecting containers
Verify deleted scripts can be re-detected via auto-detect feature

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/303 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/10/2025 **Status:** ✅ Merged **Merged:** 11/10/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/289` --- ### 📝 Commits (1) - [`b192c46`](https://github.com/community-scripts/ProxmoxVE-Local/commit/b192c46d8d1c7a0ea79ef3cf268ace02be10b717) fix: Add 'Delete only from DB' option for duplicate detected scripts ### 📊 Changes **1 file changed** (+28 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/InstalledScriptsTab.tsx` (+28 -3) </details> ### 📄 Description ## Problem Users can have duplicate detected script entries (same container_id and server_id) in the database. Currently, for SSH scripts with container_id, the only option is "Destroy" which destroys the actual container. Users need a way to delete just the database record to clean up duplicates without destroying the host/container. ## Solution Add a "Delete only from DB" option in the Actions dropdown menu for detected scripts (SSH scripts with container_id) that: - Only deletes the database record - Does NOT destroy the container - Uses a clear confirmation modal to distinguish it from "Destroy" ## Changes - Added "Delete only from DB" menu item in Actions dropdown for SSH scripts with container_id - Placed option after "Destroy" with separator to distinguish from destructive action - Updated handleDeleteScript to use confirmation modal for SSH scripts - Modal clearly states it only deletes database record, container remains intact - Allows users to clean up duplicate script entries without destroying containers ## Testing - Verify Delete only removes the database record - Verify Destroy still works as before (destroys container + deletes record) - Verify duplicate scripts can be cleaned up without affecting containers - Verify deleted scripts can be re-detected via auto-detect feature --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>