[PR #282] [MERGED] Fix x button vertical centering in filter scripts search bar #326

New issue

Closed

opened 2026-02-26 12:41:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:41:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/282
Author: @michelroegl-brunner
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/273

📝 Commits (1)

e460a05 Fix x button vertical centering in filter scripts search bar

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 src/app/_components/FilterBar.tsx (+1 -2)

📄 Description

Changes

Fixed vertical centering of the x (clear) button in the filter scripts search bar
Removed size='icon' constraint that was limiting button height to 36px
Changed positioning to use inset-y-0 with h-full to match the full input field height
Added flex items-center justify-center for proper icon centering within the button

Fixes

Button now properly centers vertically within the input field
Hover background now matches the full input height in both light and dark themes
Resolves issue where hover background appeared shorter than the input field

Testing

Verified button is vertically centered
Verified hover state background matches input height in both themes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/282 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/273` --- ### 📝 Commits (1) - [`e460a05`](https://github.com/community-scripts/ProxmoxVE-Local/commit/e460a05f9114526567a00c11c733e150f649cc1b) Fix x button vertical centering in filter scripts search bar ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/FilterBar.tsx` (+1 -2) </details> ### 📄 Description ## Changes - Fixed vertical centering of the x (clear) button in the filter scripts search bar - Removed `size='icon'` constraint that was limiting button height to 36px - Changed positioning to use `inset-y-0` with `h-full` to match the full input field height - Added `flex items-center justify-center` for proper icon centering within the button ## Fixes - Button now properly centers vertically within the input field - Hover background now matches the full input height in both light and dark themes - Resolves issue where hover background appeared shorter than the input field ## Testing - Verified button is vertically centered - Verified hover state background matches input height in both themes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>