[PR #278] [MERGED] Fix: Include 'New' scripts in Download All Filtered when no filters are active #322

New issue

Closed

opened 2026-02-26 12:40:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:40:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/278
Author: @michelroegl-brunner
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/253

📝 Commits (1)

75d52c7 Fix: Include 'New' scripts in Download All Filtered when no filters are active

📊 Changes

1 file changed (+24 additions, -1 deletions)

View changed files

📝 src/app/_components/ScriptsGrid.tsx (+24 -1)

📄 Description

Problem

When no filters are active, clicking 'Download All Filtered' only downloads scripts from the lower section (main grid) and excludes scripts from the 'Newest Scripts' carousel.

Solution

Modified handleDownloadAllFiltered to include all scripts when no filters are active:

When no filters are active: Combines filteredScripts and newestScripts (deduplicated by slug)
When filters are active: Uses filteredScripts as before (maintains existing behavior)

Changes

Updated handleDownloadAllFiltered in ScriptsGrid.tsx to check if filters are active
When no filters are active, merges both filtered and newest scripts to ensure all scripts are included
Ensures no duplicate scripts are downloaded

Testing

✅ No filters active: All scripts (including 'New' carousel) are downloaded
✅ Filters active: Only filtered scripts are downloaded (existing behavior maintained)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/278 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/253` --- ### 📝 Commits (1) - [`75d52c7`](https://github.com/community-scripts/ProxmoxVE-Local/commit/75d52c771f11bcca0c9a16554aa7626a943f92a3) Fix: Include 'New' scripts in Download All Filtered when no filters are active ### 📊 Changes **1 file changed** (+24 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/ScriptsGrid.tsx` (+24 -1) </details> ### 📄 Description ## Problem When no filters are active, clicking 'Download All Filtered' only downloads scripts from the lower section (main grid) and excludes scripts from the 'Newest Scripts' carousel. ## Solution Modified `handleDownloadAllFiltered` to include all scripts when no filters are active: - When no filters are active: Combines `filteredScripts` and `newestScripts` (deduplicated by slug) - When filters are active: Uses `filteredScripts` as before (maintains existing behavior) ## Changes - Updated `handleDownloadAllFiltered` in `ScriptsGrid.tsx` to check if filters are active - When no filters are active, merges both filtered and newest scripts to ensure all scripts are included - Ensures no duplicate scripts are downloaded ## Testing - ✅ No filters active: All scripts (including 'New' carousel) are downloaded - ✅ Filters active: Only filtered scripts are downloaded (existing behavior maintained) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>