[PR #121] [MERGED] feat: Multi-select script download with progress tracking #223

New issue

Closed

opened 2026-02-26 12:40:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:40:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/121
Author: @michelroegl-brunner
Created: 10/13/2025
Status: ✅ Merged
Merged: 10/13/2025
Merged by: @michelroegl-brunner

Base: main ← Head: feat/multiple-downloads

📝 Commits (3)

08df457 feat: Add multi-select script download with progress tracking
3a19a81 fix: Resolve ESLint errors
28cbaa1 fix: Resolve TypeScript error in loadMultipleScripts

📊 Changes

6 files changed (+446 additions, -72 deletions)

View changed files

➖ scripts/ct/debian.sh (+0 -43)
➖ scripts/install/debian-install.sh (+0 -24)
📝 src/app/_components/ScriptCard.tsx (+31 -2)
📝 src/app/_components/ScriptCardList.tsx (+32 -3)
📝 src/app/_components/ScriptsGrid.tsx (+331 -0)
📝 src/server/api/routers/scripts.ts (+52 -0)

📄 Description

🚀 Multi-Select Script Download Feature

This PR adds comprehensive multi-selection functionality for downloading scripts with real-time progress tracking and improved user experience.

✨ Features Added

🎯 Multi-Selection

Checkbox Selection: Added checkboxes to both card and list views
Select All Visible: Button to select all scripts in current filtered view
Clear Selection: Button to deselect all scripts
View Switching: Selection clears when switching between card/list views

📊 Progress Tracking

Real-time Progress: Individual script downloads with actual progress updates
Visual Indicators:
- ✓ Successfully downloaded (green)
- ✗ Failed download (red)
- ⟳ Currently downloading (blue with pulse)
- ○ Pending (gray)
Current Script Display: Shows which script is currently being downloaded
Progress Bar: Animated bar showing completion percentage

🔄 Download Actions

Download Selected: Downloads only selected scripts from visible set
Download All Filtered: Downloads all scripts in current filtered view
Individual Downloads: Each script downloads independently for better error handling

🎨 User Experience

Persistent Progress Bar: Stays visible until manually dismissed
Manual Dismiss: X button appears when download completes
Real-time Card Updates: Cards update download status immediately after completion
User-friendly Errors: Specific, actionable error messages instead of generic failures

🛠️ Technical Improvements

Error Handling: Comprehensive error message translation for better user guidance
State Management: Proper cleanup and state synchronization
API Integration: Uses existing loadScript API for individual downloads
TypeScript: Full type safety with proper interfaces

🎯 Key Benefits

Better UX: Users can select multiple scripts and download them efficiently
Real Progress: No more fake progress bars - shows actual download progress
Clear Feedback: Users know exactly what's happening and why something failed
Flexible Selection: Works with filtered views and category selections
Error Recovery: Detailed error messages help users understand and fix issues

🧪 Testing

Multi-select functionality works in both card and list views
Progress bar shows real-time updates during downloads
Error messages are user-friendly and actionable
Card status updates immediately after download completion
Selection clears when switching between views
Progress bar persists until manually dismissed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/121 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/13/2025 **Status:** ✅ Merged **Merged:** 10/13/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `feat/multiple-downloads` --- ### 📝 Commits (3) - [`08df457`](https://github.com/community-scripts/ProxmoxVE-Local/commit/08df457d52329eeff9a6931c46b88dbec3f916c2) feat: Add multi-select script download with progress tracking - [`3a19a81`](https://github.com/community-scripts/ProxmoxVE-Local/commit/3a19a811704c8b599b4711224accfe04423eb344) fix: Resolve ESLint errors - [`28cbaa1`](https://github.com/community-scripts/ProxmoxVE-Local/commit/28cbaa1f8a1b8802b38bff0f0c8de74a47afd8c1) fix: Resolve TypeScript error in loadMultipleScripts ### 📊 Changes **6 files changed** (+446 additions, -72 deletions) <details> <summary>View changed files</summary> ➖ `scripts/ct/debian.sh` (+0 -43) ➖ `scripts/install/debian-install.sh` (+0 -24) 📝 `src/app/_components/ScriptCard.tsx` (+31 -2) 📝 `src/app/_components/ScriptCardList.tsx` (+32 -3) 📝 `src/app/_components/ScriptsGrid.tsx` (+331 -0) 📝 `src/server/api/routers/scripts.ts` (+52 -0) </details> ### 📄 Description ## 🚀 Multi-Select Script Download Feature This PR adds comprehensive multi-selection functionality for downloading scripts with real-time progress tracking and improved user experience. ### ✨ Features Added #### 🎯 Multi-Selection - **Checkbox Selection**: Added checkboxes to both card and list views - **Select All Visible**: Button to select all scripts in current filtered view - **Clear Selection**: Button to deselect all scripts - **View Switching**: Selection clears when switching between card/list views #### 📊 Progress Tracking - **Real-time Progress**: Individual script downloads with actual progress updates - **Visual Indicators**: - ✓ Successfully downloaded (green) - ✗ Failed download (red) - ⟳ Currently downloading (blue with pulse) - ○ Pending (gray) - **Current Script Display**: Shows which script is currently being downloaded - **Progress Bar**: Animated bar showing completion percentage #### 🔄 Download Actions - **Download Selected**: Downloads only selected scripts from visible set - **Download All Filtered**: Downloads all scripts in current filtered view - **Individual Downloads**: Each script downloads independently for better error handling #### 🎨 User Experience - **Persistent Progress Bar**: Stays visible until manually dismissed - **Manual Dismiss**: X button appears when download completes - **Real-time Card Updates**: Cards update download status immediately after completion - **User-friendly Errors**: Specific, actionable error messages instead of generic failures #### 🛠️ Technical Improvements - **Error Handling**: Comprehensive error message translation for better user guidance - **State Management**: Proper cleanup and state synchronization - **API Integration**: Uses existing loadScript API for individual downloads - **TypeScript**: Full type safety with proper interfaces ### 🎯 Key Benefits - **Better UX**: Users can select multiple scripts and download them efficiently - **Real Progress**: No more fake progress bars - shows actual download progress - **Clear Feedback**: Users know exactly what's happening and why something failed - **Flexible Selection**: Works with filtered views and category selections - **Error Recovery**: Detailed error messages help users understand and fix issues ### 🧪 Testing - [x] Multi-select functionality works in both card and list views - [x] Progress bar shows real-time updates during downloads - [x] Error messages are user-friendly and actionable - [x] Card status updates immediately after download completion - [x] Selection clears when switching between views - [x] Progress bar persists until manually dismissed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>