[PR #73] [MERGED] feat: Add prominent LXC creation completion message #195

New issue

Closed

opened 2026-02-26 12:40:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 12:40:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/73
Author: @michelroegl-brunner
Created: 10/8/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @michelroegl-brunner

Base: main ← Head: feat/finish_block

📝 Commits (6)

9c2e5f7 feat: Add prominent LXC creation completion message
3142c38 Merge branch 'main' into feat/finish_block
4c18514 Delete scripts/ct/debian.sh
67bc6b9 Delete scripts/install/debian-install.sh
73e3a72 Fix linting errors in Terminal.tsx
4e07c81 Remove duplicate handleMessage function

📊 Changes

1 file changed (+56 additions, -40 deletions)

View changed files

📝 src/app/_components/Terminal.tsx (+56 -40)

📄 Description

Description

This PR adds a prominent completion message for LXC creation scripts to make it more obvious when the LXC creation process has finished successfully.

Changes

Enhanced Terminal component to detect LXC creation scripts
Display prominent block message when LXC creation finishes successfully
Detection based on script path (ct/), container ID, and script name patterns
Maintains backward compatibility for non-LXC scripts
Shows 'LXC CREATION FINISHED' block instead of standard completion message

Testing

LXC creation scripts now display a prominent completion block
Non-LXC scripts continue to show the standard completion message
Detection works for various LXC script patterns

Screenshot

When an LXC creation script finishes successfully, users will now see:

#########################################
########## LXC CREATION FINISHED ########
#########################################

Instead of the standard 'SSH script execution finished with code: 0' message.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/73 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/8/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `feat/finish_block` --- ### 📝 Commits (6) - [`9c2e5f7`](https://github.com/community-scripts/ProxmoxVE-Local/commit/9c2e5f700a200225b4ce0860b97aa1b9a37e3ea7) feat: Add prominent LXC creation completion message - [`3142c38`](https://github.com/community-scripts/ProxmoxVE-Local/commit/3142c38ea4b8c2e6d26ffd8ff17466023b5a6df8) Merge branch 'main' into feat/finish_block - [`4c18514`](https://github.com/community-scripts/ProxmoxVE-Local/commit/4c1851486a72fee699d21ac0d4422f2ee1f8cff4) Delete scripts/ct/debian.sh - [`67bc6b9`](https://github.com/community-scripts/ProxmoxVE-Local/commit/67bc6b9947aac20c66c152f2e6112701c26effba) Delete scripts/install/debian-install.sh - [`73e3a72`](https://github.com/community-scripts/ProxmoxVE-Local/commit/73e3a7235659922a42f5af8e1adb162449506ea1) Fix linting errors in Terminal.tsx - [`4e07c81`](https://github.com/community-scripts/ProxmoxVE-Local/commit/4e07c81441903c2aa7c825371a63dd4cec79eca0) Remove duplicate handleMessage function ### 📊 Changes **1 file changed** (+56 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/Terminal.tsx` (+56 -40) </details> ### 📄 Description ## Description This PR adds a prominent completion message for LXC creation scripts to make it more obvious when the LXC creation process has finished successfully. ## Changes - Enhanced Terminal component to detect LXC creation scripts - Display prominent block message when LXC creation finishes successfully - Detection based on script path (ct/), container ID, and script name patterns - Maintains backward compatibility for non-LXC scripts - Shows 'LXC CREATION FINISHED' block instead of standard completion message ## Testing - LXC creation scripts now display a prominent completion block - Non-LXC scripts continue to show the standard completion message - Detection works for various LXC script patterns ## Screenshot When an LXC creation script finishes successfully, users will now see: ``` ######################################### ########## LXC CREATION FINISHED ######## ######################################### ``` Instead of the standard 'SSH script execution finished with code: 0' message. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>