#25 - [PR #26] [MERGED] V2.1.9 - Remote execution cancellation, live output streaming, and cu… - starred/ProxmoxScripts

## 📋 Pull Request Information **Original PR:** https://github.com/coelacant1/ProxmoxScripts/pull/26 **Author:** [@coelacant1](https://github.com/coelacant1) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@coelacant1](https://github.com/coelacant1) **Base:** `main` ← **Head:** `testing` --- ### 📝 Commits (1) - [`379f323`](https://github.com/coelacant1/ProxmoxScripts/commit/379f32387d04554025bb04500cd1a65e95131d9e) V2.1.9 - Remote execution cancellation, live output streaming, and custom port support improvements ### 📊 Changes **202 files changed** (+765 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `.check/UpdateFunctionIndex.py` (+3 -1) 📝 `.check/VerifySourceCalls.py` (+3 -1) 📝 `.check/_RunChecks.sh` (+0 -0) 📝 `.docs/GenerateContentDiff.sh` (+0 -0) 📝 `.docs/UpdatePVEGuide.sh` (+0 -0) 📝 `.site/serve.sh` (+0 -0) 📝 `CCPVE.sh` (+0 -0) 📝 `CHANGELOG.md` (+24 -0) 📝 `Cluster/AddNodes.sh` (+0 -0) 📝 `Cluster/CreateCluster.sh` (+0 -0) 📝 `Cluster/DeleteCluster.sh` (+0 -0) 📝 `Cluster/RemoveClusterNode.sh` (+0 -0) 📝 `Firewall/BulkAddFirewallLXCVM.sh` (+0 -0) 📝 `Firewall/EnableFirewallSetup.sh` (+0 -0) 📝 `GUI.sh` (+31 -18) 📝 `HighAvailability/AddResources.sh` (+0 -0) 📝 `HighAvailability/CreateHAGroup.sh` (+0 -0) 📝 `HighAvailability/DisableHAClusterWide.sh` (+0 -0) 📝 `HighAvailability/DisableHighAvailability.sh` (+0 -0) 📝 `Host/Bulk/FirstTimeProxmoxSetup.sh` (+0 -0) _...and 80 more files_ </details> ### 📄 Description …stom port support improvements ### Fixed - **Script Cancellation** - Ctrl+C now kills the remote script process via SSH - Tracks remote PID and sends targeted SIGTERM/SIGKILL on interrupt - Replaced unsafe `killall`/`pkill` with process-specific cleanup - **ArgumentParser Hyphenated Flags** - Flag names with hyphens now map correctly to variable names - Converts hyphens to underscores in variable names (e.g. `--my-flag` -> `MY_FLAG`) - **Custom Port Passthrough** - Fixed port not being passed through in manual node entry and IP/VMID range flows ### Changed - **Live Remote Output** - Remote script output now streams directly to terminal - Replaced deferred log download with real-time `tee`-based streaming - Output log still saved locally for review - **Git File Modes** - All `.sh` files tracked as executable (100755) ### Technical Details - Added `REMOTE_CURRENT_*` tracking globals and `remote_pid_file` for targeted cleanup in `__remote_cleanup__` - `__add_remote_target__` and `__clear_remote_targets__` now handle port parameter - Manual node entry prompts for SSH port in GUI single-remote, multi-IP, and multi-VMID flows - Node selection prompts for SSH port in `__select_nodes__` --- name: Pull Request about: Remote execution cancellation, live output streaming, and custom port support improvements title: "[PR] Remote execution cancellation, live output streaming, and custom port support improvements" labels: enhancement assignees: 'coelacant1' --- ## Type of Change - [x] Bug fix (non-breaking change fixing an issue) - [x] New feature (non-breaking change adding functionality) - [ ] Breaking change (fix or feature that would break existing functionality) - [ ] Documentation update - [ ] Other (please describe): ## How Has This Been Tested? Manual script execution on local and remote node to validate the remote execution cancellation as well as the remote execution logging live feedback. ## Checklist - [x] I have performed a self-review of my own code. - [x] I have commented my code where necessary. - [x] I have made corresponding changes to the documentation (if applicable). - [x] My changes do not generate new warnings or errors. - [x] I have tested this code. ## Related Issues https://github.com/coelacant1/ProxmoxScripts/issues/25 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem commented

2026-03-03 01:17:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/coelacant1/ProxmoxScripts/pull/26
Author: @coelacant1
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @coelacant1

Base: main ← Head: testing

📝 Commits (1)

379f323 V2.1.9 - Remote execution cancellation, live output streaming, and custom port support improvements

📊 Changes

202 files changed (+765 additions, -66 deletions)

View changed files

📝 .check/UpdateFunctionIndex.py (+3 -1)
📝 .check/VerifySourceCalls.py (+3 -1)
📝 .check/_RunChecks.sh (+0 -0)
📝 .docs/GenerateContentDiff.sh (+0 -0)
📝 .docs/UpdatePVEGuide.sh (+0 -0)
📝 .site/serve.sh (+0 -0)
📝 CCPVE.sh (+0 -0)
📝 CHANGELOG.md (+24 -0)
📝 Cluster/AddNodes.sh (+0 -0)
📝 Cluster/CreateCluster.sh (+0 -0)
📝 Cluster/DeleteCluster.sh (+0 -0)
📝 Cluster/RemoveClusterNode.sh (+0 -0)
📝 Firewall/BulkAddFirewallLXCVM.sh (+0 -0)
📝 Firewall/EnableFirewallSetup.sh (+0 -0)
📝 GUI.sh (+31 -18)
📝 HighAvailability/AddResources.sh (+0 -0)
📝 HighAvailability/CreateHAGroup.sh (+0 -0)
📝 HighAvailability/DisableHAClusterWide.sh (+0 -0)
📝 HighAvailability/DisableHighAvailability.sh (+0 -0)
📝 Host/Bulk/FirstTimeProxmoxSetup.sh (+0 -0)

...and 80 more files

📄 Description

…stom port support improvements

Fixed

Script Cancellation - Ctrl+C now kills the remote script process via SSH
- Tracks remote PID and sends targeted SIGTERM/SIGKILL on interrupt
- Replaced unsafe killall/pkill with process-specific cleanup
ArgumentParser Hyphenated Flags - Flag names with hyphens now map correctly to variable names
- Converts hyphens to underscores in variable names (e.g. --my-flag -> MY_FLAG)
Custom Port Passthrough - Fixed port not being passed through in manual node entry and IP/VMID range flows

Changed

Live Remote Output - Remote script output now streams directly to terminal
- Replaced deferred log download with real-time tee-based streaming
- Output log still saved locally for review
Git File Modes - All .sh files tracked as executable (100755)

Technical Details

Added REMOTE_CURRENT_* tracking globals and remote_pid_file for targeted cleanup in __remote_cleanup__
__add_remote_target__ and __clear_remote_targets__ now handle port parameter
Manual node entry prompts for SSH port in GUI single-remote, multi-IP, and multi-VMID flows
Node selection prompts for SSH port in __select_nodes__

name: Pull Request
about: Remote execution cancellation, live output streaming, and custom port support improvements
title: "[PR] Remote execution cancellation, live output streaming, and custom port support improvements"
labels: enhancement
assignees: 'coelacant1'

Type of Change

Bug fix (non-breaking change fixing an issue)
New feature (non-breaking change adding functionality)
Breaking change (fix or feature that would break existing functionality)
Documentation update
Other (please describe):

How Has This Been Tested?

Manual script execution on local and remote node to validate the remote execution cancellation as well as the remote execution logging live feedback.

Checklist

I have performed a self-review of my own code.
I have commented my code where necessary.
I have made corresponding changes to the documentation (if applicable).
My changes do not generate new warnings or errors.
I have tested this code.

https://github.com/coelacant1/ProxmoxScripts/issues/25

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem

closed this issue
added the
pull-request
label

Rows
Columns

[PR #26] [MERGED] V2.1.9 - Remote execution cancellation, live output streaming, and cu… #25