mirror of
https://github.com/PowerDNS-Admin/PowerDNS-Admin.git
synced 2026-04-25 08:45:55 +03:00
[GH-ISSUE #68] Enable/disable DNSSEC #45
Labels
No labels
bug / broken-feature
bug / broken-feature
docs / request
feature / request
help / other
mod / help-wanted
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PowerDNS-Admin-PowerDNS-Admin#45
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @joachimtingvold on GitHub (Jul 2, 2016).
Original GitHub issue: https://github.com/PowerDNS-Admin/PowerDNS-Admin/issues/68
Originally assigned to: @ivanfilippov on GitHub.
Hi,
Slightly relevant to #2 -- is PowerDNS-Admin supposed to automatically detect if a zone is DNSSEC-enabled?
Currently I have a zone that I have DNSSEC-enabled (via the proper PowerDNS utilities), and the different keys are present. The domain is still listed as "Disabled" within PowerDNS-Admin. However, clicking the "Disabled"-button, it shows the relevant DNSSEC-information.
I looked at the code, and I can't find anywhere where the
dnssecoption would be set totrue. The only place I could find, was inDomain.update(), but since there are no place to set true/false within the GUI, this option is never set (regardless ifDomain.get_domain_dnssec()is called when clicking on the "Disabled" button).@joachimtingvold commented on GitHub (Jul 2, 2016):
Another thing; the "Enabled"-button (when
dnssec = true) should probably have a green (or green-ish) background (and not the grey it currently has).@TacoScheltema commented on GitHub (Jul 3, 2016):
I totally agree with the green background for the dnssec button. I would also prefer if the width of the enabled button is the same as the disabled button, I think that would look better in the layout.
@ivanfilippov commented on GitHub (Jul 3, 2016):
@jallakim I've replicated your issue, I'll look into it.
@jallakim @TacoScheltema The button should be green, that was something I missed during the migration from the old template into the new one. I've made the fix and I'll push it alongside the rest of the fix for the problem @jallakim described.
@ivanfilippov commented on GitHub (Jul 3, 2016):
@jallakim I spoke too soon, I replicated an issue but not your specific issue. It looks like there is a delay between modifying the domain via
pdnsutiland the pdns API showing the change (the delay is somewhere between 1 and 5 seconds, and its randomness makes me think there is a rolling timer that updates the data after a change withpdnsutil), see the below log. I've bolded the times I ran the commands to show the time difference and wherepdnsutilshows that DNSSEC was enabled, and where the API shows that it's not. The pdns database is updates instantly so it seems like it's only an API delay.:powerdns-dev auth-4.0.0-alpha3 # date && pdns/pdnsutil --config-dir=. secure-zone dnssec.test Sun Jul 3 13:21:03 MDT 2016 Securing zone with default key size Adding CSK (257) with algorithm ecdsa256 Zone dnssec.test. secured Adding NSEC ordering information powerdns-dev auth-4.0.0-alpha3 # date && curl -s -H 'X-API-Key: 1234567890' http://127.0.0.1:2400/api/v1/servers/localhost/zones/dnssec.test | jq . Sun Jul 3 13:21:07 MDT 2016 { "account": "", "dnssec": false, "id": "dnssec.test.", "kind": "Native", "last_check": 0, "masters": [], "name": "dnssec.test.", "notified_serial": 0, "rrsets": [ { "comments": [], "name": "dnssec.test.", "records": [ { "content": "a.misconfigured.powerdns.server. hostmaster.dnssec.test. 2016070301 10800 3600 604800 3600", "disabled": false } ], "ttl": 3600, "type": "SOA" } ], "serial": 2016070301, "soa_edit": "", "soa_edit_api": "DEFAULT", "url": "api/v1/servers/localhost/zones/dnssec.test." }@jallakim Are you sure your button still says Disabled when the domain has DNSSEC and it's not just gray?
I've fixed the color and width issue and submitted PR #71 for them.
@joachimtingvold commented on GitHub (Jul 4, 2016):
@ngoduykhanh, this issue is not fixed. I'll look into it later today with more details/answer to @ivanfilippov's comment.
@joachimtingvold commented on GitHub (Jul 4, 2016):
The width needs to be changed;
I'll look at the other issue later.
@joachimtingvold commented on GitHub (Jul 4, 2016):
@ivanfilippov, tested it now.
dnssecis never set totrue. And as mentioned; checking the code, I can't find any place wherednssecwould be set totrue.@ngoduykhanh commented on GitHub (Jul 4, 2016):
@jallakim : I guess you are using PostgreSQL as DB backend for PowerDNS-Admin, right?.
@ivanfilippov : The issue is the
dnssecvalue isn't reloaded when we rundomain.update(). It is same issue with #61 which is related to how we store the Boolean value in the PostgreSQL.Fixed in
0bd488b9bc@ivanfilippov commented on GitHub (Jul 4, 2016):
@ngoduykhanh Nice find!
While you're in there, can you also fix the width of the buttons themselves that I tried here:
github.com/ngoduykhanh/PowerDNS-Admin@d0c40c09e5I'd say get rid of the
col-md-6and just set the width with awidth="10%or something similar (like we do for the edit and delete buttons in the domain.html template)@joachimtingvold commented on GitHub (Jul 4, 2016):
@ngoduykhanh, correct, I'm using PostgreSQL as backend.
@ngoduykhanh commented on GitHub (Jul 4, 2016):
The width of DNSSEC column can be changed when the use resize their windows. I can't make sure 10% or something similar can fit the text so I set it to 100% width of the column in
7a0327d290for the quick fix. It looks good to me, let me know if you don't like it :D@joachimtingvold commented on GitHub (Jul 4, 2016):
Works like a charm now. Thanks!
The 100% width is fine by me. Maybe a bit "intrusive" (due to it's size), but at least much better than "Enabled" and "Disabled" both being gray (-:
@liudonghua123 commented on GitHub (Apr 30, 2024):
I use pschiffe/pdns-mysql docker image which I need to config
PDNS_gmysql_dnssec=yesenv to enable DNSSEC, see also https://github.com/pschiffe/docker-pdns/issues/82.