starred/PowerDNS-Admin-PowerDNS-Admin

Fork 0

mirror of https://github.com/PowerDNS-Admin/PowerDNS-Admin.git synced 2026-04-25 08:45:55 +03:00

[GH-ISSUE #66] Gravatar #44

New issue

Closed

opened 2026-02-26 10:35:47 +03:00 by kerem · 6 comments

kerem commented

2026-02-26 10:35:47 +03:00

Owner

Originally created by @joachimtingvold on GitHub (Jul 2, 2016).
Original GitHub issue: https://github.com/PowerDNS-Admin/PowerDNS-Admin/issues/66

Hi,

Could Gravatar-support be added, as an alternative to uploading avatars?

Originally created by @joachimtingvold on GitHub (Jul 2, 2016). Original GitHub issue: https://github.com/PowerDNS-Admin/PowerDNS-Admin/issues/66 Hi, Could Gravatar-support be added, as an alternative to uploading avatars?

kerem closed this issue

2026-02-26 10:35:47 +03:00

kerem commented

2026-02-26 10:35:47 +03:00

Author

Owner

@ivanfilippov commented on GitHub (Jul 13, 2016):

@ngoduykhanh

Can you review and assist if you can with this? I have it working here github.com/ivanfilippov/PowerDNS-Admin@c22f3424f6

But I feel like there should be a better way than injecting the local variable on user load. I tried to make it a local variable in the model but it doesn't stick around. There's an option to make a custom Jinja filter to do md5 hashes, but I'm not sure if that's a better solution.

@ivanfilippov commented on GitHub (Jul 13, 2016): @ngoduykhanh Can you review and assist if you can with this? I have it working here https://github.com/ivanfilippov/PowerDNS-Admin/commit/c22f3424f6b03e66b4b90c3c3a9659924b66cb86 But I feel like there should be a better way than injecting the local variable on user load. I tried to make it a local variable in the model but it doesn't stick around. There's an option to make a custom Jinja filter to do md5 hashes, but I'm not sure if that's a better solution.

kerem commented

2026-02-26 10:35:48 +03:00

Author

Owner

@ngoduykhanh commented on GitHub (Jul 13, 2016):

Hi @ivanfilippov ,

Honestly I don't like the idea of adding one more value in the model for this purpose. We better to use Jinja filter, it is more flexible.

Please take a look at my gravatar branch with commit 3edf9b01fa

Thanks.

@ngoduykhanh commented on GitHub (Jul 13, 2016): Hi @ivanfilippov , Honestly I don't like the idea of adding one more value in the model for this purpose. We better to use Jinja filter, it is more flexible. Please take a look at my `gravatar` branch with commit 3edf9b01faac33bc5b6574256490f85e3f2c2253 Thanks.

kerem commented

2026-02-26 10:35:48 +03:00

Author

Owner

@ivanfilippov commented on GitHub (Jul 13, 2016):

@ngoduykhanh Nice, I like it!

If you'd like, I think you can simplify the code a bit since I don't think we need to check for SSL. It should be ok and error-free to request gravatars over HTTPS even when PDNS-Admin is loaded over HTTP, as opposed to the other way around which would cause errors.

👍

@ivanfilippov commented on GitHub (Jul 13, 2016): @ngoduykhanh Nice, I like it! If you'd like, I think you can simplify the code a bit since I don't think we need to check for SSL. It should be ok and error-free to request gravatars over HTTPS even when PDNS-Admin is loaded over HTTP, as opposed to the other way around which would cause errors. :+1:

kerem commented

2026-02-26 10:35:48 +03:00

Author

Owner

@ngoduykhanh commented on GitHub (Jul 13, 2016):

@ivanfilippov : do you mean forcing to load gravatar with HTTPS even PowerDNS-Admin is loaded over HTTP? If yes, I am ok with that too since we won't waste server resource to check if the connection is SECURE in every request :D

@ngoduykhanh commented on GitHub (Jul 13, 2016): @ivanfilippov : do you mean forcing to load gravatar with HTTPS even PowerDNS-Admin is loaded over HTTP? If yes, I am ok with that too since we won't waste server resource to check if the connection is SECURE in every request :D

kerem commented

2026-02-26 10:35:48 +03:00

Author

Owner

@ivanfilippov commented on GitHub (Jul 13, 2016):

Yes that's what I meant!

@ivanfilippov commented on GitHub (Jul 13, 2016): Yes that's what I meant!

kerem commented

2026-02-26 10:35:48 +03:00

Author

Owner

@ngoduykhanh commented on GitHub (Jul 13, 2016):

OK, removed the SSL check and added this enhancement into master branch. Thanks.

@ngoduykhanh commented on GitHub (Jul 13, 2016): OK, removed the SSL check and added this enhancement into `master` branch. Thanks.

kerem referenced this issue

2026-02-26 10:36:00 +03:00

[GH-ISSUE #112] Differences between pdns 3.4.2 and 3.4.1? #70