[GH-ISSUE #13] Support for PowerDNS 4.x #10

Closed
opened 2026-02-26 10:35:27 +03:00 by kerem · 14 comments
Owner

Originally created by @TacoScheltema on GitHub (Mar 13, 2016).
Original GitHub issue: https://github.com/PowerDNS-Admin/PowerDNS-Admin/issues/13

Hi,

Will you be supporting PowerDNS 4.x? I got it to work nicely on version 3 but on 4 I can only see the domains, not the records under a domain (I get a 500 error then).

Cheers,
Taco

Originally created by @TacoScheltema on GitHub (Mar 13, 2016). Original GitHub issue: https://github.com/PowerDNS-Admin/PowerDNS-Admin/issues/13 Hi, Will you be supporting PowerDNS 4.x? I got it to work nicely on version 3 but on 4 I can only see the domains, not the records under a domain (I get a 500 error then). Cheers, Taco
kerem 2026-02-26 10:35:27 +03:00
Author
Owner

@ngoduykhanh commented on GitHub (Mar 17, 2016):

PowerDNS 4 still in Alpha release. But I will start working on this to make sure PowerDNS-Admin can work with the new version of PowerDNS.

<!-- gh-comment-id:197872303 --> @ngoduykhanh commented on GitHub (Mar 17, 2016): PowerDNS 4 still in Alpha release. But I will start working on this to make sure PowerDNS-Admin can work with the new version of PowerDNS.
Author
Owner

@Trozz commented on GitHub (Apr 28, 2016):

any movement on this?

<!-- gh-comment-id:215334981 --> @Trozz commented on GitHub (Apr 28, 2016): any movement on this?
Author
Owner

@ivanfilippov commented on GitHub (May 6, 2016):

I've started a very naive implementation of pdns 4 support in a new branch. You'll need to add /api/v1/ to the end of your PDNS_STATS_URL in config.py when configuring the new code.

It works in my test environment with pdns 4.0.0-alpha1, but I would appreciate feedback from others.

The branch can be found here: https://github.com/ivanfilippov/PowerDNS-Admin/tree/pdns4-support

<!-- gh-comment-id:217573641 --> @ivanfilippov commented on GitHub (May 6, 2016): I've started a very naive implementation of pdns 4 support in a new branch. You'll need to add `/api/v1/` to the end of your PDNS_STATS_URL in `config.py` when configuring the new code. It works in my test environment with pdns 4.0.0-alpha1, but I would appreciate feedback from others. The branch can be found here: https://github.com/ivanfilippov/PowerDNS-Admin/tree/pdns4-support
Author
Owner

@ivanfilippov commented on GitHub (May 15, 2016):

Spoke too soon, this will need quite a bit more work to work properly with pdns4.

<!-- gh-comment-id:219317367 --> @ivanfilippov commented on GitHub (May 15, 2016): Spoke too soon, this will need quite a bit more work to work properly with pdns4.
Author
Owner

@ngoduykhanh commented on GitHub (Jun 7, 2016):

@ivanfilippov : I've pushed some adjustments to support pdns v4.x.x in our new_ui branch.
Features are working:

  • Add a domain
  • Show domain/record table
  • Adding a records.

Still have problem with multiple records adding which described at https://github.com/ngoduykhanh/PowerDNS-Admin/issues/5#issuecomment-181637576 in my adjustment.

Let me know if you have any idea/adjustment.

<!-- gh-comment-id:224238325 --> @ngoduykhanh commented on GitHub (Jun 7, 2016): @ivanfilippov : I've pushed some adjustments to support pdns v4.x.x in our `new_ui` branch. Features are working: - Add a domain - Show domain/record table - Adding a records. Still have problem with multiple records adding which described at https://github.com/ngoduykhanh/PowerDNS-Admin/issues/5#issuecomment-181637576 in my adjustment. Let me know if you have any idea/adjustment.
Author
Owner

@ivanfilippov commented on GitHub (Jun 8, 2016):

@ngoduykhanh I fixed the multiple record adding issue in this commit: github.com/ivanfilippov/PowerDNS-Admin@812aa055f8

During testing I noticed that the new PDNS API won't accept MX or SRV records unless they are suffixed by a '.'. This looks like it's part of the spec for MX and SRV records, so I'll work on adding that in as well just for the new API code.

<!-- gh-comment-id:224470411 --> @ivanfilippov commented on GitHub (Jun 8, 2016): @ngoduykhanh I fixed the multiple record adding issue in this commit: https://github.com/ivanfilippov/PowerDNS-Admin/commit/812aa055f858c09e4324ad043e8172821264df4d During testing I noticed that the new PDNS API won't accept MX or SRV records unless they are suffixed by a '.'. This looks like it's part of the spec for MX and SRV records, so I'll work on adding that in as well just for the new API code.
Author
Owner

@ivanfilippov commented on GitHub (Jun 8, 2016):

@ngoduykhanh I fixed the '.' issue with MX and SRV records I mentioned above, but I'm not sure that the way I fixed it is the best way. Can you review it? Commit here: github.com/ivanfilippov/PowerDNS-Admin@b9f57e8cfe

<!-- gh-comment-id:224472987 --> @ivanfilippov commented on GitHub (Jun 8, 2016): @ngoduykhanh I fixed the '.' issue with MX and SRV records I mentioned above, but I'm not sure that the way I fixed it is the best way. Can you review it? Commit here: https://github.com/ivanfilippov/PowerDNS-Admin/commit/b9f57e8cfec5addc0e278f9228904c610ee2cf38
Author
Owner

@ngoduykhanh commented on GitHub (Jun 8, 2016):

@ivanfilippov : I am OK with your change. But it looks like we need more than MX and SRV here. CNAME, NS also requires trailing dot in their content.

p/s: pdns v4.x.x requires to add a trailing dot in the records name and content, but the trailing dots aren't saved in the pdns's database actually :)

<!-- gh-comment-id:224474974 --> @ngoduykhanh commented on GitHub (Jun 8, 2016): @ivanfilippov : I am OK with your change. But it looks like we need more than `MX` and `SRV` here. `CNAME`, `NS` also requires trailing dot in their content. p/s: pdns v4.x.x requires to add a trailing dot in the records `name` and `content`, but the trailing dots aren't saved in the pdns's database actually :)
Author
Owner

@ivanfilippov commented on GitHub (Jun 8, 2016):

@ngoduykhanh I noticed that the pdns database does not save the dots as well, but pdns itself must add them when responding to queries. I wonder why they decided to do that.

We'll need to add CNAME and NS to this line: github.com/ivanfilippov/PowerDNS-Admin@b9f57e8cfe (commitcomment-17781503)

Go ahead and add those two in if you're free, I won't have a chance to look at it until tomorrow. 😄

<!-- gh-comment-id:224475737 --> @ivanfilippov commented on GitHub (Jun 8, 2016): @ngoduykhanh I noticed that the pdns database does not save the dots as well, but pdns itself must add them when responding to queries. I wonder why they decided to do that. We'll need to add CNAME and NS to this line: https://github.com/ivanfilippov/PowerDNS-Admin/commit/b9f57e8cfec5addc0e278f9228904c610ee2cf38#commitcomment-17781503 Go ahead and add those two in if you're free, I won't have a chance to look at it until tomorrow. :smile:
Author
Owner

@ngoduykhanh commented on GitHub (Jun 8, 2016):

@ivanfilippov : I see. I will take care of adding those two in. thanks Ivan.

<!-- gh-comment-id:224476166 --> @ngoduykhanh commented on GitHub (Jun 8, 2016): @ivanfilippov : I see. I will take care of adding those two in. thanks Ivan.
Author
Owner

@ngoduykhanh commented on GitHub (Jun 8, 2016):

Pushed commit aad9d92038 for those changes.

<!-- gh-comment-id:224481842 --> @ngoduykhanh commented on GitHub (Jun 8, 2016): Pushed commit aad9d920389d675f19dd7f28b41c53ccb6f2d12c for those changes.
Author
Owner

@ivanfilippov commented on GitHub (Jun 8, 2016):

@ngoduykhanh

Thanks!

By the way, I'm going to remove my own new_ui branch and push directly to the one in your repo, having my own branch and keeping it in sync is becoming a pain. 😄

<!-- gh-comment-id:224484861 --> @ivanfilippov commented on GitHub (Jun 8, 2016): @ngoduykhanh Thanks! By the way, I'm going to remove my own `new_ui` branch and push directly to the one in your repo, having my own branch and keeping it in sync is becoming a pain. :smile:
Author
Owner

@ngoduykhanh commented on GitHub (Jun 8, 2016):

@ivanfilippov
Yes, you should do that. Thanks buddy :)

<!-- gh-comment-id:224486162 --> @ngoduykhanh commented on GitHub (Jun 8, 2016): @ivanfilippov Yes, you should do that. Thanks buddy :)
Author
Owner

@ngoduykhanh commented on GitHub (Jun 26, 2016):

PDNS 4.x.x is supported now with PR #50 . Feel free to open issues related to PDNS 4.x.x compatibilities.

<!-- gh-comment-id:228600181 --> @ngoduykhanh commented on GitHub (Jun 26, 2016): PDNS 4.x.x is supported now with PR #50 . Feel free to open issues related to PDNS 4.x.x compatibilities.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PowerDNS-Admin-PowerDNS-Admin#10
No description provided.