[GH-ISSUE #1603] [Feature]: Check whether an app downloaded from library is an IPA #998

Open
opened 2026-03-03 19:02:53 +03:00 by kerem · 4 comments
Owner

Originally created by @einstein95 on GitHub (Jul 19, 2024).
Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/1603

A recent change made the download for Genshin Impact resolve to what is presumably an error page. PlayCover tries to parse this as a zip file, giving a central directory error.
See #1597

Describe the solution you'd like

To not give the same error as an incomplete zip file.

Anything else?

N/A

Issue Language

  • Yes my issue is written in English
Originally created by @einstein95 on GitHub (Jul 19, 2024). Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/1603 ### Is your feature request related to a problem? A recent change made the download for Genshin Impact resolve to what is presumably an error page. PlayCover tries to parse this as a zip file, giving a central directory error. See #1597 ### Describe the solution you'd like To not give the same error as an incomplete zip file. ### Anything else? N/A ### Issue Language - [X] Yes my issue is written in English
Author
Owner

@Catta1997 commented on GitHub (Jul 19, 2024):

The "problem" of the Genshin Impact IPA is that it is a Google Drive file, I added a way to detect if it's a GD file and return the correct download link. The error "zip file" is 99.99% a "Quota Limit reached" error of Google Drive (in that specific case). The only way to detect it is check every time there is a download if the page has a "quota limit" text but is too much "expensive"

<!-- gh-comment-id:2239430483 --> @Catta1997 commented on GitHub (Jul 19, 2024): The "problem" of the Genshin Impact IPA is that it is a Google Drive file, I added a way to detect if it's a GD file and return the correct download link. The error "zip file" is 99.99% a "Quota Limit reached" error of Google Drive (in that specific case). The only way to detect it is check every time there is a download if the page has a "quota limit" text but is too much "expensive"
Author
Owner

@einstein95 commented on GitHub (Jul 20, 2024):

The only way to detect it is check every time there is a download if the page has a "quota limit" text but is too much "expensive"

I was thinking less of a "get the right download link from parsing the page" and more "the file that was downloaded isn't an IPA, tell user"

<!-- gh-comment-id:2240958682 --> @einstein95 commented on GitHub (Jul 20, 2024): > The only way to detect it is check every time there is a download if the page has a "quota limit" text but is too much "expensive" I was thinking less of a "get the right download link from parsing the page" and more "the file that was downloaded isn't an IPA, tell user"
Author
Owner

@TheMoonThatRises commented on GitHub (Aug 28, 2024):

This is technically already implemented, as the IPA library has a SHA256 hash checker. However, the issue is that IPA providers currently do not provide the SHA256 hash.

<!-- gh-comment-id:2315698548 --> @TheMoonThatRises commented on GitHub (Aug 28, 2024): This is technically already implemented, as the IPA library has a SHA256 hash checker. However, the issue is that IPA providers currently do not provide the SHA256 hash.
Author
Owner

@wzs82043215 commented on GitHub (Sep 14, 2024):

库的链接麻烦发一下呗

<!-- gh-comment-id:2351100678 --> @wzs82043215 commented on GitHub (Sep 14, 2024): 库的链接麻烦发一下呗
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#998
No description provided.