mirror of
https://github.com/PlayCover/PlayCover.git
synced 2026-04-26 00:05:52 +03:00
[GH-ISSUE #1603] [Feature]: Check whether an app downloaded from library is an IPA #998
Labels
No labels
UI
app-support
bug
bug
documentation
duplicate
enhancement
game-support
good first issue
help wanted / caution
inactive
invalid
macos-beta
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PlayCover#998
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @einstein95 on GitHub (Jul 19, 2024).
Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/1603
Is your feature request related to a problem?
A recent change made the download for Genshin Impact resolve to what is presumably an error page. PlayCover tries to parse this as a zip file, giving a central directory error.
See #1597
Describe the solution you'd like
To not give the same error as an incomplete zip file.
Anything else?
N/A
Issue Language
@Catta1997 commented on GitHub (Jul 19, 2024):
The "problem" of the Genshin Impact IPA is that it is a Google Drive file, I added a way to detect if it's a GD file and return the correct download link. The error "zip file" is 99.99% a "Quota Limit reached" error of Google Drive (in that specific case). The only way to detect it is check every time there is a download if the page has a "quota limit" text but is too much "expensive"
@einstein95 commented on GitHub (Jul 20, 2024):
I was thinking less of a "get the right download link from parsing the page" and more "the file that was downloaded isn't an IPA, tell user"
@TheMoonThatRises commented on GitHub (Aug 28, 2024):
This is technically already implemented, as the IPA library has a SHA256 hash checker. However, the issue is that IPA providers currently do not provide the SHA256 hash.
@wzs82043215 commented on GitHub (Sep 14, 2024):
库的链接麻烦发一下呗