[GH-ISSUE #1516] [Bug]: Resolution: Auto does not take notch into account #934

Closed
opened 2026-03-03 19:02:19 +03:00 by kerem · 3 comments
Owner

Originally created by @mitchellmebane on GitHub (Jun 15, 2024).
Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/1516

Describe the bug

I have a 16" MacBook Pro M2 Max. The physical screen resolution is 3,456 x 2234. When used in the normal Retina mode, the logical screen resolution is 1,728 x 1,117. However, because this MacBook has a notched display, the safe area under the notch is smaller, with a logical resolution of 1,728 x 1,080.

When PlayCover's "Auto" resolution setting is used, it detects the resolution of the whole screen. However, Genshin Impact (at least) only displays in the safe area, which means 1,728 x 1,117 is the wrong aspect ratio, resulting in pillarboxing. If I set a Custom resolution of 1,728 x 1,080, Genshin properly fills the whole safe area.

(Actually, it's even a bit weirder... Auto says it's 1,728 x 1,117 but usually behaves like it's 1,920 x 1,080, so I get letterboxing).

Steps to reproduce

  1. In the PlayCover app settings for Genshin Impact, on the Graphics tab, set the Device to "iPad Pro (12.9-inch) (6th gen) | M2 | 8GB" and the Resolution to Auto (Based on Display)
  2. Observe that the Detected Resolution is 1,728 x 1,117.
  3. Start Genshin and move the mouse cursor to the sides of the screen.
  4. Observe that there is pillarboxing.

Expected behaviour

  1. In the PlayCover app settings for Genshin Impact, on the Graphics tab, set the Resolution to Auto (Based on Display)
  2. Observe that the Detected Resolution is 1,728 x 1,080.
  3. Start Genshin and move the mouse cursor to the sides of the screen.
  4. Genshin fills the entire area under the notch, and there is no pillarboxing or letterboxing.

Crash log

N/A

What version of PlayCover are you using?

Nightly 774

What version of macOS are you using?

Sonoma (macOS 14.5)

Issue Language

  • Yes my issue is written in English
Originally created by @mitchellmebane on GitHub (Jun 15, 2024). Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/1516 ### Describe the bug I have a 16" MacBook Pro M2 Max. The physical screen resolution is 3,456 x 2234. When used in the normal Retina mode, the logical screen resolution is 1,728 x 1,117. However, because this MacBook has a notched display, the safe area under the notch is smaller, with a logical resolution of 1,728 x 1,080. When PlayCover's "Auto" resolution setting is used, it detects the resolution of the whole screen. However, Genshin Impact (at least) only displays in the safe area, which means 1,728 x 1,117 is the wrong aspect ratio, resulting in pillarboxing. If I set a Custom resolution of 1,728 x 1,080, Genshin properly fills the whole safe area. (Actually, it's even a bit weirder... Auto _says_ it's 1,728 x 1,117 but usually behaves like it's 1,920 x 1,080, so I get letterboxing). ### Steps to reproduce 1. In the PlayCover app settings for Genshin Impact, on the Graphics tab, set the Device to "iPad Pro (12.9-inch) (6th gen) | M2 | 8GB" and the Resolution to Auto (Based on Display) 2. Observe that the Detected Resolution is 1,728 x 1,117. 3. Start Genshin and move the mouse cursor to the sides of the screen. 4. Observe that there is pillarboxing. ### Expected behaviour 1. In the PlayCover app settings for Genshin Impact, on the Graphics tab, set the Resolution to Auto (Based on Display) 2. Observe that the Detected Resolution is 1,728 x 1,080. 3. Start Genshin and move the mouse cursor to the sides of the screen. 4. Genshin fills the entire area under the notch, and there is no pillarboxing or letterboxing. ### Crash log ```shell N/A ``` ### What version of PlayCover are you using? Nightly 774 ### What version of macOS are you using? Sonoma (macOS 14.5) ### Issue Language - [X] Yes my issue is written in English
kerem 2026-03-03 19:02:19 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@mitchellmebane commented on GitHub (Jun 15, 2024):

If I first set the resolution to "App Default" and then switch to "Auto", it says the Detected Resolution is 1,728 x 1,117 but behaves like 1,920 x 1,080.

If I first set the resolution to "Custom" with 1,728 x 1,080 and then switch to "Auto", it says the Detected Resolution is 1,728 x 1,117 and behaves like 1,728 x 1,117. I don't really understand how Auto is working here.

<!-- gh-comment-id:2170357071 --> @mitchellmebane commented on GitHub (Jun 15, 2024): If I first set the resolution to "App Default" and then switch to "Auto", it says the Detected Resolution is 1,728 x 1,117 but behaves like 1,920 x 1,080. If I first set the resolution to "Custom" with 1,728 x 1,080 and then switch to "Auto", it says the Detected Resolution is 1,728 x 1,117 and behaves like 1,728 x 1,117. I don't really understand how Auto is working here.
Author
Owner

@mitchellmebane commented on GitHub (Jun 27, 2024):

I found the resolution calculation code in PlayCover/Views/AppSettingsView.swift and it looks like it should be taking the notch into account. 😕

<!-- gh-comment-id:2192930160 --> @mitchellmebane commented on GitHub (Jun 27, 2024): I found the resolution calculation code in `PlayCover/Views/AppSettingsView.swift` and it looks like it should be taking the notch into account. 😕
Author
Owner

@mitchellmebane commented on GitHub (Jun 27, 2024):

Oh, the notch detection is done by checking the machine's model number against a hard-coded list, and my 16" M2 MacBook Pro is not in that list.

<!-- gh-comment-id:2193303475 --> @mitchellmebane commented on GitHub (Jun 27, 2024): Oh, the notch detection is done by checking the machine's model number against a hard-coded list, and my 16" M2 MacBook Pro is not in that list.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#934
No description provided.