mirror of
https://github.com/PlayCover/PlayCover.git
synced 2026-04-26 00:05:52 +03:00
[GH-ISSUE #1516] [Bug]: Resolution: Auto does not take notch into account #934
Labels
No labels
UI
app-support
bug
bug
documentation
duplicate
enhancement
game-support
good first issue
help wanted / caution
inactive
invalid
macos-beta
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PlayCover#934
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mitchellmebane on GitHub (Jun 15, 2024).
Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/1516
Describe the bug
I have a 16" MacBook Pro M2 Max. The physical screen resolution is 3,456 x 2234. When used in the normal Retina mode, the logical screen resolution is 1,728 x 1,117. However, because this MacBook has a notched display, the safe area under the notch is smaller, with a logical resolution of 1,728 x 1,080.
When PlayCover's "Auto" resolution setting is used, it detects the resolution of the whole screen. However, Genshin Impact (at least) only displays in the safe area, which means 1,728 x 1,117 is the wrong aspect ratio, resulting in pillarboxing. If I set a Custom resolution of 1,728 x 1,080, Genshin properly fills the whole safe area.
(Actually, it's even a bit weirder... Auto says it's 1,728 x 1,117 but usually behaves like it's 1,920 x 1,080, so I get letterboxing).
Steps to reproduce
Expected behaviour
Crash log
What version of PlayCover are you using?
Nightly 774
What version of macOS are you using?
Sonoma (macOS 14.5)
Issue Language
@mitchellmebane commented on GitHub (Jun 15, 2024):
If I first set the resolution to "App Default" and then switch to "Auto", it says the Detected Resolution is 1,728 x 1,117 but behaves like 1,920 x 1,080.
If I first set the resolution to "Custom" with 1,728 x 1,080 and then switch to "Auto", it says the Detected Resolution is 1,728 x 1,117 and behaves like 1,728 x 1,117. I don't really understand how Auto is working here.
@mitchellmebane commented on GitHub (Jun 27, 2024):
I found the resolution calculation code in
PlayCover/Views/AppSettingsView.swiftand it looks like it should be taking the notch into account. 😕@mitchellmebane commented on GitHub (Jun 27, 2024):
Oh, the notch detection is done by checking the machine's model number against a hard-coded list, and my 16" M2 MacBook Pro is not in that list.