mirror of
https://github.com/PlayCover/PlayCover.git
synced 2026-04-26 00:05:52 +03:00
[GH-ISSUE #1359] [App Support]: Naver Series #803
Labels
No labels
UI
app-support
bug
bug
documentation
duplicate
enhancement
game-support
good first issue
help wanted / caution
inactive
invalid
macos-beta
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PlayCover#803
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @exploitJ on GitHub (Jan 28, 2024).
Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/1359
App Store link
Naver Series - App Store
Current issues
More details
Crash log
What version of PlayCover are you using?
3.0.0 beta 2
What version of macOS are you using?
Sonoma (macOS 14)
Issue Language
@s7v3n7 commented on GitHub (Jan 29, 2024):
MacOS sucks.
@Ryu-ga commented on GitHub (Feb 2, 2024):
The app crash with this log.
NaverSeries[39255:4137666] [NaverLoginModule [ERROR] NLoginConnection+SharedKeychain.m -NLoginConnection(SharedKeychain) sharedKeychainResetVer2] Exception : Problem deleting current dictionary. (result=-34018)
This crash return exactly same error to https://github.com/box/box-ios-browse-sdk/issues/27, I think Naver forked this.
It seems to crash due to Keychain feature and There were some issues https://forums.developer.apple.com/forums/thread/114456 with Entitlements.
@exploitJ commented on GitHub (Feb 4, 2024):
is there any workarounds that would resolve this?
@Ryu-ga commented on GitHub (Feb 11, 2024):
I figured out why it kept crashing - I added some code for PlayTools. But now I have no idea how to log in via Other Apps. I need to implement keychain sharing for PlayChain.
Edit: PlayChain uses main logic in Swift over @objc attribute, but strange issues have occurred with double free (I am not familiar with ARC). Additionally, there is no code for
errItemNotFoundin the SecItemDelete hook. As a result, I migrated SecItem[Add, CopyMatching] to Objective-C to address the double free issue withresultin parametersCFDictionaryRef query, CFTypeRef *result.@Ryu-ga commented on GitHub (Feb 21, 2024):
Fixed Download new nightly with patched play tools. https://github.com/PlayCover/PlayCover/actions/runs/7984661791/artifacts/1261938309
@exploitJ commented on GitHub (Feb 22, 2024):
App's default should fallback to in-app web browser for login when Naver App isn't found.
Is there a way to forward the login deeplink to the browser?
@Ryu-ga commented on GitHub (Feb 22, 2024):
네이버 발 앱 전부 로그인 뷰에서 아무 설정 없이는 터치가 안 먹어서, 설정에
Touch Alternatives키고 Opt키 누른 상태로 트랙패드로 로그인 하면 그 다음부터는 터치가 되더라구요.In various apps from Naver, I couldn't touch anything in the login view without specific settings. But when I turned on the "Touch Alternatives" in the settings and logged in using the trackpad with the Opt key pressed , the touch worked from then on.
@exploitJ commented on GitHub (Feb 22, 2024):
네이버 웹툰 앱에서는
Touch Alternative설정 없이도 클릭이 잘되는데 시리즈 앱에서는 설정해도 로그인 화면으로 넘어가지 않는군요. 혹시 디버깅하는 프로세스가 있을까요? 분석에 도움이라도 되고 싶습니다.Unfortunately, Toggling
Touch Alternativesdidn't made a big difference.On the other hand, Naver WEBTOON App didn't require such workarounds in order to function.
@Ryu-ga commented on GitHub (Feb 22, 2024):
네이버 앱과 시리즈 앱은 Touch Alternative 설정을 킨 후 트랙패드로 로그인 버튼을 누르고 아이디 패스워드 창에 트랙패드로 포커스까지 줘야 그 다음부터 없이도 터치가 가능하더라구요. 그리고 일부 팝업에서도 그냥은 터치가 안되는 현상이 있네요.
@exploitJ commented on GitHub (Feb 22, 2024):
Touch Alternative 조작이 어렵군요... 겨우 로그인하고 나서는 개별앱 설정에서 key mapping을 해제하니 마우스 클릭으로 작동이 가능했습니다. 부작용으로 휠스크롤이 안되지만요.
@Ryu-ga commented on GitHub (Feb 22, 2024):
@exploitJ 휠 스크롤은 수직 스크롤뷰에 있는 횡 스크롤 뷰 위에서 스크롤을 시작하면 안되는 것인데, 아마 아무 뷰가 없거나 컨텐트가 없는 곳에서 수직 스크롤을 하시면 될겁니다. 이건 MacOS에서 UI하다보면 겪긴 하는데 해결을 어떻게 하는지는 모르겠네요.
@exploitJ commented on GitHub (Feb 22, 2024):
@Ryu-ga 감사합니다! 많이 배워갑니다.