mirror of
https://github.com/PlayCover/PlayCover.git
synced 2026-04-26 16:25:54 +03:00
[GH-ISSUE #689] [Bug]: Crash pop-up after closing games #326
Labels
No labels
UI
app-support
bug
bug
documentation
duplicate
enhancement
game-support
good first issue
help wanted / caution
inactive
invalid
macos-beta
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PlayCover#326
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @FlyMeToTheMoonAndLetMePlayAmongTheStars on GitHub (Jan 7, 2023).
Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/689
Describe the bug
PlayCover
2.0.2 (206)macOS
13.1Computer
M1 MacBook Air, 8 GB RAM, 7-core GPUDoesn't happen all the time but happens often enough to be annoying.
I noticed that if you're using the M1 identifier to play for example Genshin Impact or Honkai Impact 3rd, there's often a crash pop-up after you click on the little red dot to close the game after playing for awhile (~30 mins). Interestingly, this does not happen or happens far less frequently when using the A12Z identifier.
Steps to reproduce
Close the game with M1 identifier and do the same with A12Z (should play the game for awhile before closing it, closing on the start screen usually don't produce a crash message)
Expected behaviour
No crash message
Crash log
What version of PlayCover are you using?
Nightly/beta
What version of macOS are you using?
Ventura (macOS 13)
Issue Language
@FlyMeToTheMoonAndLetMePlayAmongTheStars commented on GitHub (Jan 30, 2023):
Doesn't seem to be exclusive to the M1 identifier. Also still getting these crash pop-ups from time to time when closing apps (more specifically Genshin Impact and Honkai Impact 3rd) on PlayCover 3.0.0 (244)/macOS 13.2
Prior versions crash log indicated SIGSEGV, now it's SIGABRT. Here's the full crash log on newer PlayCover version.
This is a minor issue since it happens after you exit the app/game, but I'll still track it here to make it known.
@ohaiibuzzle commented on GitHub (Jan 31, 2023):
Probably because on iOS you never end up terminating the game completely and abruptly like Cmd + Q on macOS
@XuYicong commented on GitHub (Dec 12, 2023):
Potential solution: post notifications like did enter background or will sleep on quiting the app. Normally iOS app would have cleanup triggers on these.
Or we can just follow this sequence
@XuYicong commented on GitHub (Dec 13, 2023):
I can reproduce this and this is indeed annoying and I have ideas to fix this
@nesk commented on GitHub (Jan 17, 2024):
I also encounter this bug, what about merging the PR provided by @XuYicong? It seems to be a reasonable fix.