[GH-ISSUE #36] Search update feature issues #20

Closed
opened 2026-03-03 18:53:47 +03:00 by kerem · 1 comment
Owner

Originally created by @Depal1 on GitHub (Jul 14, 2022).
Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/36

The search update feature on PlayCover is triggering on Github pre-releases. Is this expected behavior?

On another note, it is directing to a .zip instead of the currently used .dmg.

Example: it is directing to https://github.com/PlayCover/PlayCover/releases/download/1.0.7/PlayCover.1.0.7.zip

instead of https://github.com/PlayCover/PlayCover/releases/download/1.0.7/PlayCover_1.0.7.dmg

Originally created by @Depal1 on GitHub (Jul 14, 2022). Original GitHub issue: https://github.com/PlayCover/PlayCover/issues/36 The search update feature on PlayCover is triggering on Github pre-releases. Is this expected behavior? On another note, it is directing to a .zip instead of the currently used .dmg. Example: it is directing to https://github.com/PlayCover/PlayCover/releases/download/1.0.7/PlayCover.1.0.7.zip instead of https://github.com/PlayCover/PlayCover/releases/download/1.0.7/PlayCover_1.0.7.dmg
kerem 2026-03-03 18:53:47 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@ohaiibuzzle commented on GitHub (Jul 14, 2022):

From what I can tell, the update code doesn't really do any checking of whether or not the release is a pre-release.
And it is indeed hardcoded to .zip instead of .dmg as seen here

<!-- gh-comment-id:1184721958 --> @ohaiibuzzle commented on GitHub (Jul 14, 2022): From what I can tell, the update code doesn't really do any checking of whether or not the release is a pre-release. And it is indeed hardcoded to `.zip` instead of `.dmg` as seen [here](https://github.com/PlayCover/PlayCover/blob/cd0ad23df968be421fbfebda879e37bd59418644/PlayCover/Services/UpdateService.swift#L42)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PlayCover#20
No description provided.