[PR #1986] [MERGED] Fix build steps by rebundling PlayTools to deep framework #1936

New issue

Closed

opened 2026-03-03 19:09:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1986
Author: @JoseMoreville
Created: 9/26/2025
Status: ✅ Merged
Merged: 10/15/2025
Merged by: @TheMoonThatRises

Base: develop ← Head: build-steps-fix

📝 Commits (2)

d9b34c4 Fix compiling by rebundling PlayTools from shallow to deep fw
087508b fix script typo

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+2 -2)

📄 Description

Recent macOS/Xcode versions enforce proper deep framework structure.

We were embedding a shallow framework, which now triggers a complaint with the compiler

This PR adds a build-phase script that:

Copies PlayTools.framework (iOS slice we currently ship using Carthage with xcframeworks param).
Repackages it into a macOS deep framework.
Codesign the new PlayTools.framework

Disclaimer: This is hacky as is. We need to find a way to fix Playtools so that it can build a deep framework layout by default.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1986 **Author:** [@JoseMoreville](https://github.com/JoseMoreville) **Created:** 9/26/2025 **Status:** ✅ Merged **Merged:** 10/15/2025 **Merged by:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Base:** `develop` ← **Head:** `build-steps-fix` --- ### 📝 Commits (2) - [`d9b34c4`](https://github.com/PlayCover/PlayCover/commit/d9b34c4bc5c834b18e217aa617b822bf69027164) Fix compiling by rebundling PlayTools from shallow to deep fw - [`087508b`](https://github.com/PlayCover/PlayCover/commit/087508b09cdc5bdfa9825dd4d78467444fb7a65e) fix script typo ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+2 -2) </details> ### 📄 Description Recent macOS/Xcode versions enforce proper deep framework structure. We were embedding a shallow framework, which now triggers a complaint with the compiler This PR adds a build-phase script that: 1. Copies PlayTools.framework (iOS slice we currently ship using Carthage with xcframeworks param). 2. Repackages it into a macOS deep framework. 3. Codesign the new PlayTools.framework Disclaimer: This is hacky as is. We need to find a way to fix Playtools so that it can build a deep framework layout by default. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>