[PR #1933] [MERGED] Quality-of-Life update for multi-keymaps #1925

New issue

Closed

opened 2026-03-03 19:09:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1933
Author: @TheMoonThatRises
Created: 7/27/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @TheMoonThatRises

Base: develop ← Head: fix/qol-multikeymap

📝 Commits (8)

fbdbd6d fix default pill background in light-mode
1072cea fix keymapview closing on every action
87adad5 disallow deletion of default keymap
b17f9cb allow keymaps to be reordered
05076f9 Merge branch 'develop' into fix/qol-multikeymap
d9187e4 fix crash on app uninstall
026ccc1 seperate keymap models from class
8e817b3 reload keymap cache to generate keymap dir on load

📊 Changes

9 files changed (+293 additions, -311 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+8 -4)
➕ PlayCover/Model/KeymapData.swift (+116 -0)
📝 PlayCover/Model/PlayApp.swift (+2 -0)
📝 PlayCover/Utils/Keymapping.swift (+72 -167)
📝 PlayCover/Utils/UpdateScheme.swift (+4 -4)
📝 PlayCover/ViewModel/KeymapViewVM.swift (+23 -15)
📝 PlayCover/ViewModel/Log.swift (+4 -0)
📝 PlayCover/Views/KeymapView.swift (+64 -116)
📝 PlayCover/en.lproj/Localizable.strings (+0 -5)

📄 Description

This pull requests implements multiple changes as suggested by #1926. Note that this pull request may cause some issues to users who are on a nightly version with the previous multi-keymap implementation.

Fixes the default pill background in keymap list when in light mode.
Fixes keymap view closing after every action.
Disallow deletion of default keymaps.
Allow keymaps to be reordered.

Requires https://github.com/PlayCover/PlayTools/pull/194.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1933 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 7/27/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Base:** `develop` ← **Head:** `fix/qol-multikeymap` --- ### 📝 Commits (8) - [`fbdbd6d`](https://github.com/PlayCover/PlayCover/commit/fbdbd6d04738c076afed082c2133f49414652e74) fix `default` pill background in light-mode - [`1072cea`](https://github.com/PlayCover/PlayCover/commit/1072cea25d38314ef0a091feef9bf3ee0119dc9e) fix keymapview closing on every action - [`87adad5`](https://github.com/PlayCover/PlayCover/commit/87adad56535c02971c5916875dbb461ad5d7840d) disallow deletion of default keymap - [`b17f9cb`](https://github.com/PlayCover/PlayCover/commit/b17f9cb50283b15d4d0d5a8e60d960a690b75c59) allow keymaps to be reordered - [`05076f9`](https://github.com/PlayCover/PlayCover/commit/05076f9b6880deb45f74c8acdb7b799507fe8e0a) Merge branch 'develop' into fix/qol-multikeymap - [`d9187e4`](https://github.com/PlayCover/PlayCover/commit/d9187e4ac48462dad4ef1dbad9bf062435d1839d) fix crash on app uninstall - [`026ccc1`](https://github.com/PlayCover/PlayCover/commit/026ccc1456b3811a5c270305c5d804c57f3e22f9) seperate keymap models from class - [`8e817b3`](https://github.com/PlayCover/PlayCover/commit/8e817b3d6c25f6d808842f5e07cd604e2289e69c) reload keymap cache to generate keymap dir on load ### 📊 Changes **9 files changed** (+293 additions, -311 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+8 -4) ➕ `PlayCover/Model/KeymapData.swift` (+116 -0) 📝 `PlayCover/Model/PlayApp.swift` (+2 -0) 📝 `PlayCover/Utils/Keymapping.swift` (+72 -167) 📝 `PlayCover/Utils/UpdateScheme.swift` (+4 -4) 📝 `PlayCover/ViewModel/KeymapViewVM.swift` (+23 -15) 📝 `PlayCover/ViewModel/Log.swift` (+4 -0) 📝 `PlayCover/Views/KeymapView.swift` (+64 -116) 📝 `PlayCover/en.lproj/Localizable.strings` (+0 -5) </details> ### 📄 Description This pull requests implements multiple changes as suggested by #1926. Note that this pull request may cause some issues to users who are on a nightly version with the previous multi-keymap implementation. - Fixes the `default` pill background in keymap list when in light mode. - Fixes keymap view closing after every action. - Disallow deletion of default keymaps. - Allow keymaps to be reordered. Requires https://github.com/PlayCover/PlayTools/pull/194. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>