[PR #1917] [MERGED] Feature: optional feature to hide titlebar #1922

New issue

Closed

opened 2026-03-03 19:09:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1917
Author: @JoseMoreville
Created: 7/7/2025
Status: ✅ Merged
Merged: 7/30/2025
Merged by: @JoseMoreville

Base: develop ← Head: develop

📝 Commits (5)

88ce2e7 feat: users can now hide apps titlebar
394aa21 Merge branch 'PlayCover:develop' into develop
d0e9fad linting
dfef870 Update .swiftlint.yml
cf740de Update .swiftlint.yml

📊 Changes

3 files changed (+10 additions, -13 deletions)

View changed files

📝 PlayCover/Model/AppSettings.swift (+2 -0)
📝 PlayCover/Views/AppSettingsView.swift (+7 -13)
📝 PlayCover/en.lproj/Localizable.strings (+1 -0)

📄 Description

This pull request introduces a new feature to hide the title bar in the application settings. The changes span multiple files to implement the feature, update the user interface, and add localization support.

Feature Implementation:

PlayCover/Model/AppSettings.swift: Added a new property hideTitleBar to the AppSettingsData struct and updated the decoding logic to handle this property with a default value of false. [1] [2]

User Interface Updates:

PlayCover/Views/AppSettingsView.swift:
- Introduced a new @AppStorage binding for hideTitleBar in the GraphicsView struct.
- Added a toggle UI element for hideTitleBar in the settings view, allowing users to enable or disable the feature.

Localization:

PlayCover/en.lproj/Localizable.strings: Added a localized string for the new toggle option, "Hide titlebar".

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1917 **Author:** [@JoseMoreville](https://github.com/JoseMoreville) **Created:** 7/7/2025 **Status:** ✅ Merged **Merged:** 7/30/2025 **Merged by:** [@JoseMoreville](https://github.com/JoseMoreville) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (5) - [`88ce2e7`](https://github.com/PlayCover/PlayCover/commit/88ce2e794aae41b89fea4fb50dc36af9c39ebbef) feat: users can now hide apps titlebar - [`394aa21`](https://github.com/PlayCover/PlayCover/commit/394aa21a4188e87906b121183c49de9ee9b88995) Merge branch 'PlayCover:develop' into develop - [`d0e9fad`](https://github.com/PlayCover/PlayCover/commit/d0e9fadbc2fce7a3a80687c8073a226f7e4befac) linting - [`dfef870`](https://github.com/PlayCover/PlayCover/commit/dfef870b429228bef8babe069ec5384259ad9142) Update .swiftlint.yml - [`cf740de`](https://github.com/PlayCover/PlayCover/commit/cf740de5f6ca4d9e9b0b96fca520179258caab31) Update .swiftlint.yml ### 📊 Changes **3 files changed** (+10 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/Model/AppSettings.swift` (+2 -0) 📝 `PlayCover/Views/AppSettingsView.swift` (+7 -13) 📝 `PlayCover/en.lproj/Localizable.strings` (+1 -0) </details> ### 📄 Description This pull request introduces a new feature to hide the title bar in the application settings. The changes span multiple files to implement the feature, update the user interface, and add localization support. ### Feature Implementation: * [`PlayCover/Model/AppSettings.swift`](diffhunk://#diff-3f57cf6f40ef6e282ae2799f270543767060ac9405adaaf8a2ecc1f89d79d269R44): Added a new property `hideTitleBar` to the `AppSettingsData` struct and updated the decoding logic to handle this property with a default value of `false`. [[1]](diffhunk://#diff-3f57cf6f40ef6e282ae2799f270543767060ac9405adaaf8a2ecc1f89d79d269R44) [[2]](diffhunk://#diff-3f57cf6f40ef6e282ae2799f270543767060ac9405adaaf8a2ecc1f89d79d269R75) ### User Interface Updates: * `PlayCover/Views/AppSettingsView.swift`: - Introduced a new `@AppStorage` binding for `hideTitleBar` in the `GraphicsView` struct. - Added a toggle UI element for `hideTitleBar` in the settings view, allowing users to enable or disable the feature. ### Localization: * [`PlayCover/en.lproj/Localizable.strings`](diffhunk://#diff-c81219d3648ed083c147833f2b91fee16fa3e375249183f98a8eb8e2080970e4R171): Added a localized string for the new toggle option, "Hide titlebar". related to: https://github.com/PlayCover/PlayTools/pull/191 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>