[PR #1814] [MERGED] Fix empty async image url string #1916

New issue

Closed

opened 2026-03-03 19:09:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1814
Author: @TheMoonThatRises
Created: 1/28/2025
Status: ✅ Merged
Merged: 6/29/2025
Merged by: @TheMoonThatRises

Base: develop ← Head: fix/async-image-empty-url

📝 Commits (1)

025af53 fix: empty async image url string

📊 Changes

5 files changed (+40 additions, -8 deletions)

View changed files

📝 PlayCover.xcodeproj/project.pbxproj (+4 -0)
📝 PlayCover/Views/App Views/StoreAppView.swift (+4 -4)
➕ PlayCover/Views/CachedAsyncImageWrapper.swift (+28 -0)
📝 PlayCover/Views/Sidebar Views/IPALibraryView.swift (+0 -1)
📝 PlayCover/Views/StoreInfoAppView.swift (+4 -3)

📄 Description

Provides a layer between CachedAsyncImage to check for nil and empty input url strings.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1814 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 6/29/2025 **Merged by:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Base:** `develop` ← **Head:** `fix/async-image-empty-url` --- ### 📝 Commits (1) - [`025af53`](https://github.com/PlayCover/PlayCover/commit/025af53713662baef9309176d1ca5bbc791c5ea9) fix: empty async image url string ### 📊 Changes **5 files changed** (+40 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover.xcodeproj/project.pbxproj` (+4 -0) 📝 `PlayCover/Views/App Views/StoreAppView.swift` (+4 -4) ➕ `PlayCover/Views/CachedAsyncImageWrapper.swift` (+28 -0) 📝 `PlayCover/Views/Sidebar Views/IPALibraryView.swift` (+0 -1) 📝 `PlayCover/Views/StoreInfoAppView.swift` (+4 -3) </details> ### 📄 Description Provides a layer between `CachedAsyncImage` to check for `nil` and empty input url strings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>