[PR #1762] [MERGED] MacOS detect #1905

New issue

Closed

opened 2026-03-03 19:09:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1762
Author: @Catta1997
Created: 12/7/2024
Status: ✅ Merged
Merged: 12/19/2024
Merged by: @TheMoonThatRises

Base: develop ← Head: macOSDetectRework

📝 Commits (8)

5298f8f Update IPA.swift
a264369 removed unused function and variable
57fc64c Fix crash
26dd35b fix title and alert severity
b9eb66f Added suppressionButton
789e670 changed function name
a89f64e Alert title
c26adf2 Removed unused variable

📊 Changes

6 files changed (+55 additions, -20 deletions)

View changed files

📝 PlayCover/AppInstaller/Downloader.swift (+2 -1)
📝 PlayCover/AppInstaller/Installer.swift (+1 -1)
📝 PlayCover/Utils/Extensions/PlayAppExtensions.swift (+0 -11)
📝 PlayCover/Utils/IPA.swift (+45 -6)
📝 PlayCover/Views/Settings/InstallSettings.swift (+5 -0)
📝 PlayCover/en.lproj/Localizable.strings (+2 -1)

📄 Description

Changed how PlayCover detect if an app has macOS version, in this way is no more necessary to add manually bundleID

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1762 **Author:** [@Catta1997](https://github.com/Catta1997) **Created:** 12/7/2024 **Status:** ✅ Merged **Merged:** 12/19/2024 **Merged by:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Base:** `develop` ← **Head:** `macOSDetectRework` --- ### 📝 Commits (8) - [`5298f8f`](https://github.com/PlayCover/PlayCover/commit/5298f8ff54984066521c6f890f9806c9e15510aa) Update IPA.swift - [`a264369`](https://github.com/PlayCover/PlayCover/commit/a26436965d26de2b8288a9ac9ae2f05ac9da7340) removed unused function and variable - [`57fc64c`](https://github.com/PlayCover/PlayCover/commit/57fc64c38bbf9429c98b1957367f0b4733c6e621) Fix crash - [`26dd35b`](https://github.com/PlayCover/PlayCover/commit/26dd35bc047c11ea6207e5ba3a91bcef6a29bafb) fix title and alert severity - [`b9eb66f`](https://github.com/PlayCover/PlayCover/commit/b9eb66ff900287119466ce19883d2ccc26059c78) Added suppressionButton - [`789e670`](https://github.com/PlayCover/PlayCover/commit/789e67053d22e5374ee64d1f355e0614c424c539) changed function name - [`a89f64e`](https://github.com/PlayCover/PlayCover/commit/a89f64e6cfbcccb1798fadd853fb490a7576d432) Alert title - [`c26adf2`](https://github.com/PlayCover/PlayCover/commit/c26adf2cfb6c177111070a49e1e31d7001215362) Removed unused variable ### 📊 Changes **6 files changed** (+55 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/AppInstaller/Downloader.swift` (+2 -1) 📝 `PlayCover/AppInstaller/Installer.swift` (+1 -1) 📝 `PlayCover/Utils/Extensions/PlayAppExtensions.swift` (+0 -11) 📝 `PlayCover/Utils/IPA.swift` (+45 -6) 📝 `PlayCover/Views/Settings/InstallSettings.swift` (+5 -0) 📝 `PlayCover/en.lproj/Localizable.strings` (+2 -1) </details> ### 📄 Description Changed how PlayCover detect if an app has macOS version, in this way is no more necessary to add manually bundleID --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>