[PR #1677] [MERGED] Fix build warnings and swift errors #1898

New issue

Closed

opened 2026-03-03 19:09:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 19:09:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PlayCover/PlayCover/pull/1677
Author: @TheMoonThatRises
Created: 9/13/2024
Status: ✅ Merged
Merged: 9/24/2024
Merged by: @XuYicong

Base: develop ← Head: chore/fix-swiftlint

📝 Commits (1)

7b3eb88 chore: build warnings and swift errors

📊 Changes

6 files changed (+24 additions, -20 deletions)

View changed files

📝 PlayCover/AppInstaller/Downloader.swift (+2 -2)
📝 PlayCover/Services/SoundDeviceService.swift (+6 -2)
📝 PlayCover/Utils/Extensions/URLExtensions.swift (+1 -1)
📝 PlayCover/Utils/Shell.swift (+5 -5)
📝 PlayCover/Views/AppSettingsView.swift (+5 -4)
📝 PlayCover/Views/MenuBarView.swift (+5 -6)

📄 Description

Fix swiftlint errors and Swift build warnings.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PlayCover/PlayCover/pull/1677 **Author:** [@TheMoonThatRises](https://github.com/TheMoonThatRises) **Created:** 9/13/2024 **Status:** ✅ Merged **Merged:** 9/24/2024 **Merged by:** [@XuYicong](https://github.com/XuYicong) **Base:** `develop` ← **Head:** `chore/fix-swiftlint` --- ### 📝 Commits (1) - [`7b3eb88`](https://github.com/PlayCover/PlayCover/commit/7b3eb885e327c5686eceec67f9e67e4cf614bf10) chore: build warnings and swift errors ### 📊 Changes **6 files changed** (+24 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `PlayCover/AppInstaller/Downloader.swift` (+2 -2) 📝 `PlayCover/Services/SoundDeviceService.swift` (+6 -2) 📝 `PlayCover/Utils/Extensions/URLExtensions.swift` (+1 -1) 📝 `PlayCover/Utils/Shell.swift` (+5 -5) 📝 `PlayCover/Views/AppSettingsView.swift` (+5 -4) 📝 `PlayCover/Views/MenuBarView.swift` (+5 -6) </details> ### 📄 Description Fix swiftlint errors and Swift build warnings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>